Last modified: 2014-08-15 18:38:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70557, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68557 - Disabling CodeEditor while not logged in throws JavaScript error
Disabling CodeEditor while not logged in throws JavaScript error
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeEditor (Other open bugs)
unspecified
All All
: Unprioritized minor (vote)
: ---
Assigned To: Derk-Jan Hartman
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-25 09:01 UTC by Michael M.
Modified: 2014-08-15 18:38 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Michael M. 2014-07-25 09:01:36 UTC 
Steps to reproduce:
1. Log out, open a page CodeEditor works on for editing.
2. Click the CodeEditor icon to disable it.

Of course saving to preferences fails, but additionally a JavaScript error is thrown: TypeError: mw.log.error is not a function

This error isn't visible unless you look for it, and it doesn't prevent further execution, but it shouldn't be there in any case.
Comment 1 Gerrit Notification Bot 2014-08-14 20:18:39 UTC 
Change 154128 had a related patch set uploaded by TheDJ:
Undefined function mw.log.error

https://gerrit.wikimedia.org/r/154128
Comment 2 Gerrit Notification Bot 2014-08-14 20:23:20 UTC 
Change 154128 merged by jenkins-bot:
Undefined function mw.log.error

https://gerrit.wikimedia.org/r/154128
Comment 3 Derk-Jan Hartman 2014-08-15 18:38:06 UTC 
undefined should be fixed. Other issue is part of the larger rewrite of how code editor integrates with the rest of the stuff, that i'm working on.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links