Last modified: 2006-08-16 11:48:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 6838 - Special:Makesysop gives unrelated move page message
Special:Makesysop gives unrelated move page message
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Makesysop (Other open bugs)
unspecified
All All
: Normal minor with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-07-28 03:21 UTC by Nick Jenkins
Modified: 2006-08-16 11:48 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Incomplete patch, as outlined above (461 bytes, patch)
2006-07-28 03:22 UTC, Nick Jenkins
Details
Complete patch based on Nick Jenkins' (568 bytes, patch)
2006-08-10 19:39 UTC, Aryeh Gregor (not reading bugmail, please e-mail directly)
Details

Description Nick Jenkins 2006-07-28 03:21:58 UTC
As anon viewing [[Special:Makesysop]] gets an unrelated message (about not being
able to move pages), which does not seem necessary (as there is a permission
check shortly after this anyway).

The message the anon sees is "You must be a registered user and logged in to
move a page."

Perhaps something like this:
=================================================
-if ( $wgUser->isAnon() or $wgUser->isBlocked() ) {
+if ( $wgUser->isBlocked() ) {
-   $wgOut->errorpage( "movenologin", "movenologintext" );
+   $wgOut->errorpage( /* some kind of standard message to say "you're blocked"?
*/ );
 return;
 }
=================================================

I don't know what the appropriate error page for a blocked user is, but
presumably there is already something that handles this. Will attach a rough
diff shortly (but it still needs updating of the error page line).
Comment 1 Nick Jenkins 2006-07-28 03:22:46 UTC
Created attachment 2160 [details]
Incomplete patch, as outlined above
Comment 2 Raimond Spekking 2006-08-10 09:27:36 UTC
There should be used a message from r15997 ([[MediaWiki:badaccess-groups]] oder
[[MediaWiki:badaccess-group2]]).
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-08-10 19:39:53 UTC
Created attachment 2214 [details]
Complete patch based on Nick Jenkins'

(In reply to comment #0)
> I don't know what the appropriate error page for a blocked user is, but
> presumably there is already something that handles this.

Apparently $wgOut->blockedPage();.

(In reply to comment #2)
> There should be used a message from r15997 ([[MediaWiki:badaccess-groups]]
oder
> [[MediaWiki:badaccess-group2]]).

Yes, the call to $wgOut->permissionRequired a few lines later does this.
Comment 4 Rotem Liss 2006-08-16 11:48:16 UTC
r16090.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links