Last modified: 2006-10-11 06:24:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T8835, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 6835 - Please delete the getTemplateArgs() method from Parser.php if it is not called


Summary:	Please delete the getTemplateArgs() method from Parser.php if it is not called

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	1.8.x
Hardware:	All All

Importance:	Lowest trivial with 1 vote (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	code_quality
	Show dependency tree / graph

Reported:	2006-07-28 02:50 UTC by Nick Jenkins
Modified:	2006-10-11 06:24 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Nick Jenkins 2006-07-28 02:50:34 UTC

The getTemplateArgs() function in Parser.php does not appear to be called:
-------------------------------------------
root@bling:/var/www/hosts/mediawiki/wiki# grep -inr getTemplateArgs *
../extensions/*
includes/.svn/text-base/Parser.php.svn-base:2602:       function
getTemplateArgs( $argsString ) {
includes/Parser.php:2602:       function getTemplateArgs( $argsString ) {
root@bling:/var/www/hosts/mediawiki/wiki#
-------------------------------------------

Can we maybe kill it?

Comment 1 Phil Boswell 2006-10-10 07:21:36 UTC

Is this possibly to allow extensions to gain access to template parameters so they can decode {{{parameter}}}?

I recall this being an issue a little while back...

Comment 2 Nick Jenkins 2006-10-11 06:24:44 UTC

Removed in r16925 (could not see any external extensions using this, and if it's
removed now it gives the maximum window of opportunity for it to be added back
in case someone somewhere turns out to be using it). Marking as resolved.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links