Last modified: 2008-08-06 17:41:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T8795, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 6795 - Usable Skin Names Logic Belongs in Skin Class
Usable Skin Names Logic Belongs in Skin Class
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User preferences (Other open bugs)
1.8.x
PC Linux
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2006-07-23 21:41 UTC by Gregory Szorc
Modified: 2008-08-06 17:41 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Moves logic to Skin class as new method (1.91 KB, patch)
2006-07-23 21:42 UTC, Gregory Szorc 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Gregory Szorc 2006-07-23 21:41:27 UTC 
The logic to see if a skin is usable (not in $wgSkipSkins) should be in the skin
class, not in the code that powers Special:UserPreferences.
Comment 1 Gregory Szorc 2006-07-23 21:42:38 UTC 
Created attachment 2143 [details]
Moves logic to Skin class as new method

Attached patch moves logic to skin class as getUsableSkinNames(). 
SpecialPreferences is updated to use this function.
Comment 2 Chad H. 2008-08-06 17:41:37 UTC 
Fixed in r38729
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links