Last modified: 2010-05-15 15:56:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T8759, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 6759 - Preview on first edit shows a wrong warning in REL1_6
Preview on first edit shows a wrong warning in REL1_6
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2006-07-20 19:03 UTC by Rick DeNatale
Modified: 2010-05-15 15:56 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Rick DeNatale 2006-07-20 19:03:34 UTC
At least on 1.6.7 and 1.6.8, if a user is logged on, and has "preview on first
edit" turned on in his user preferences, attempting to edit a page will fail
showing a message that session data has been lost.

Turning the preference off allows editing.

I discovered the workaround for this via a google search, in a posting to
mediawiki-l Brion asked another user who was having a problem with losing
session data whether he had the preference turned on.

Bug 6477 might be a duplicate of this but it seem to have more preconditions.
Comment 1 Ryan Marks 2006-07-20 19:26:32 UTC
For my 1.6.8 installation, I have never had the preference "preview on first
edit" enabled.  The error message I see when editing a page that has not been
created before is

Sorry! We could not process your edit due to a loss of session data. Please try
again. If it still doesn't work, try logging out and logging back in.
Comment 2 Jason Sousa 2006-07-31 22:55:03 UTC
In 1.6.7 this problem will occur with the "preview on first edit" preference
disabled because whether it is enabled or not, mediawiki tries to show you a
preview. I'm not sure if it's exactly the same in 1.6.8.

Either way, it seems to be resolved in 1.7.1.

Hope that helps.
Comment 3 Rick DeNatale 2006-08-01 00:23:51 UTC
In response to Jason, on 1.6.7 turning off preview on first edit the problem
DOES NOT occur.

Comment 4 Travis D 2006-09-18 20:37:21 UTC
There seems to be a few things happening here, and it has to do with

EditPage:tokenOk is never called in this situation, so tokenOk is false when
getPreviewText is called. Perhaps this should be changed from 

if ($this->mTokenOk)


if ( $this->tokenOk($wgRequest) )

And there's never a wpEditToken passed through the request in this situation,
since no form is posted, only the edit page is displayed. What should happen
isn't clear, perhaps a special case should be added to getPreviewText to detect
a POST, and if there's no post, there's no reason to check the token. 

if (!$wgRequest->wasPosted() || $this->tokenOk($wgRequest) )

This seems to fix the problem on our site.

Comment 5 Rotem Liss 2006-09-19 12:13:04 UTC
It was already fixed for REL1_7 (which means 1.7.0 and 1.7.1) and trunk,
apparently in r14633. Naturally, I can reproduce this bug in REL1_6 (1.6.8), but
neither in REL1_7 (1.7.1) nor in trunk. I'm not sure if r14633 should be
backported to REL1_6.

If you don't upgrade, you can just edit the page, regardless this warning - it
doesn't prevent editing.
Comment 6 Rob Church 2007-01-08 14:18:25 UTC
Issue was fixed in a stable release version; closing.

Note You need to log in before you can comment on or make changes to this bug.