Last modified: 2014-10-03 00:29:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69514, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67514 - When wiki is read-only (wgReadOnly), mobile editor doesn't know what to do
When wiki is read-only (wgReadOnly), mobile editor doesn't know what to do
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-04 00:58 UTC by Ryan Kaldari
Modified: 2014-10-03 00:29 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Kaldari 2014-07-04 00:58:18 UTC
Right now, if you try to edit an article on mobile while the database is in read-only mode, it gives you the error message "Error, can't load section." and leaves the spinner spinning forever.

Ideally, the mobile editor should detect the 'readonly' error code, close the editing overlay, and give an appropriate error message. Here is a sample API response from when the database is locked:
{"servedby":"deployment-apache02","error":{"code":"readonly","info":"The wiki is currently in read-only mode","readonlyreason":"The database has been automatically locked while the slave database servers catch up to the master"}}
Comment 1 Florian 2014-07-07 15:27:34 UTC
Hmm, i have tested it, but i can go through the edit workflow (get the section loaded into editor and get the preview too). If i try to save, i get the error, that the edit can't be saved (correctly, the db is locked). Did i anything wrong?

actual master version
Used stable
Try to edit first section of existing (non-protected) article

(Or do you mean the error message after try to save?)
Comment 2 Bingle 2014-07-07 17:20:36 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ija1pbwE
Comment 3 Jon 2014-09-19 21:17:38 UTC
Since this only happens when database is locked I don't think this is so pressing.

Sounds like we just need to improve error handling when that error kicks it and should be easy to fix with a unit test.
Comment 4 Gerrit Notification Bot 2014-10-02 19:23:44 UTC
Change 164407 had a related patch set uploaded by Bmansurov:
Show the correct error message when saving in EditorOverlay when the database is in readonly mode.

https://gerrit.wikimedia.org/r/164407
Comment 5 Gerrit Notification Bot 2014-10-03 00:00:19 UTC
Change 164407 merged by jenkins-bot:
Indicate read-only error in EditorOverlay

https://gerrit.wikimedia.org/r/164407

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links