Last modified: 2014-09-09 18:18:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68938, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66938 - ApiFlickrBlacklistTest::testBlacklistMatchByNsid fails
ApiFlickrBlacklistTest::testBlacklistMatchByNsid fails
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-22 05:04 UTC by Ori Livneh
Modified: 2014-09-09 18:18 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ori Livneh 2014-06-22 05:04:42 UTC
1) ApiFlickrBlacklistTest::testBlacklistMatchByNsid
blacklist does not match
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'bad'
+'ok'

/srv/mediawiki/extensions/UploadWizard/tests/phpunit/ApiFlickrBlacklistTest.php:186
/srv/mediawiki/extensions/UploadWizard/tests/phpunit/ApiFlickrBlacklistTest.php:52
/srv/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
Comment 1 Ori Livneh 2014-06-23 20:36:43 UTC
It's actually three tests that are failing:

PHPUnit 4.1.3 by Sebastian Bergmann.

Configuration read from /srv/mediawiki/tests/phpunit/suite.xml

FFF.................................................

Time: 38.4 seconds, Memory: 20.72Mb

There were 3 failures:

1) ApiFlickrBlacklistTest::testBlacklistMatchByNsid
blacklist does not match
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'bad'
+'ok'

/srv/mediawiki/extensions/UploadWizard/tests/phpunit/ApiFlickrBlacklistTest.php:186
/srv/mediawiki/extensions/UploadWizard/tests/phpunit/ApiFlickrBlacklistTest.php:52
/srv/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42

2) ApiFlickrBlacklistTest::testBlacklistMatchByUsername
blacklist does not match
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'bad'
+'ok'

/srv/mediawiki/extensions/UploadWizard/tests/phpunit/ApiFlickrBlacklistTest.php:186
/srv/mediawiki/extensions/UploadWizard/tests/phpunit/ApiFlickrBlacklistTest.php:70
/srv/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42

3) ApiFlickrBlacklistTest::testBlacklistMatchWithMultipleItems
blacklist does not match
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'bad'
+'ok'

/srv/mediawiki/extensions/UploadWizard/tests/phpunit/ApiFlickrBlacklistTest.php:186
/srv/mediawiki/extensions/UploadWizard/tests/phpunit/ApiFlickrBlacklistTest.php:82
/srv/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42

FAILURES!
Tests: 52, Assertions: 70, Failures: 3.
Comment 2 Bawolff (Brian Wolff) 2014-06-23 21:18:14 UTC
This appears to be caused by not having network access to the tests (Apparently it treats unable to read flickr api response as image is ok...)
Comment 3 Gerrit Notification Bot 2014-06-23 21:28:33 UTC
Change 141582 had a related patch set uploaded by Brian Wolff:
Make unit tests be skipped if no network.

https://gerrit.wikimedia.org/r/141582
Comment 4 Gerrit Notification Bot 2014-06-24 17:25:10 UTC
Change 141582 merged by jenkins-bot:
Make unit tests be skipped if no network.

https://gerrit.wikimedia.org/r/141582
Comment 5 Andre Klapper 2014-08-17 11:22:38 UTC
All patches mentioned in this report were merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Comment 6 Mark Holmquist 2014-09-09 18:18:42 UTC
This looks fixed to me.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links