Last modified: 2014-07-16 12:13:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68438, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66438 - Additional javascript:void() introduced by new suggester
Additional javascript:void() introduced by new suggester
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=0
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-10 17:23 UTC by Thiemo Mättig
Modified: 2014-07-16 12:13 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Thiemo Mättig 2014-06-10 17:23:47 UTC
This is an issue in the new ("ooMenu" based) suggester.

It introduces lots of additional href="javascript:void(0);" where the old suggester just used empty <a> elements. Most of these (if not all) don't make much sense from a usability point of view. The <a> elements are created by JavaScript code. There is no way you can see them with JavaScript disabled. Yes, it would be very nice if all clickable elements in the UI have a appropriate href="..." attribute so I can middle click, right click or Ctrl+click all these elements. But void() just isn't anything that adds any value. It's the opposite by definition. It actually makes things worse because it tricks the browser into thinking there is something in the link, it tries to execute it but then it does nothing.

TL;DR: Either use real URLs in href's that can be opened in new browser tabs or just remove these href attributes.
Comment 1 Henning 2014-06-30 07:08:53 UTC
https://github.com/wmde/ValueView/pull/77

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links