Last modified: 2006-10-04 01:49:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T8617, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 6617 - PHP notice from Language.php on bad input to Special:Undelete


Summary:	PHP notice from Language.php on bad input to Special:Undelete

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Special pages (Other open bugs)
Version:	1.8.x
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-07-10 07:33 UTC by Nick Jenkins
Modified:	2006-10-04 01:49 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch to add getTimestamp() method to WebRequest, and have SpecialUndelete call that. (2.38 KB, patch) 2006-10-03 08:23 UTC, Nick Jenkins	Details
Add an attachment (proposed patch, testcase, etc.)

Description Nick Jenkins 2006-07-10 07:33:08 UTC

Command:
======================================
curl --silent --include \
 -F 'target'='Fred'\
 -F 'timestamp'='{{66666665555555}}'\
 '192.168.0.64/wiki/index.php?title=Special:Undelete' | head -20
======================================

HTML output includes:
======================================
<br />
<b>Notice</b>:  Undefined offset:  65 in
<b>/var/www/hosts/mediawiki/phase3/languages/Language.php</b> on line
<b>479</b><br />
======================================

Comment 1 Nick Jenkins 2006-07-10 07:35:27 UTC

Forgot to add this is with "error_reporting (E_ALL);". Also user has access to
Special:Undelete.

Comment 2 Antoine "hashar" Musso (WMF) 2006-07-10 21:01:06 UTC

We use WebRequest::getText to get the timestamp, it is then
used as a key in an array of messages.

Maybe we could use a getTimestamp method. Seems harmless.

Comment 3 Nick Jenkins 2006-10-03 08:23:14 UTC

Created attachment 2431 [details]
Patch to add getTimestamp() method to WebRequest, and have SpecialUndelete call that.

Also includes a minimal fix for a minor PHP notice in includes/Revision.php
that was only visible after applying the above (PHP output was "<b>Notice</b>: 
Undefined property:  Revision::$mTextRow in
<b>/var/www/hosts/mediawiki/phase3/includes/Revision.php</b> on line
<b>704</b><br />").

Comment 4 Brion Vibber 2006-10-03 17:40:08 UTC

It should just use getVal() and normalize through wfTimestamp().

Comment 5 Brion Vibber 2006-10-03 18:42:41 UTC

Fixed in r16766.

Comment 6 Nick Jenkins 2006-10-04 01:49:49 UTC

Thank you!

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links