Last modified: 2014-11-17 11:06:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68159, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66159 - Language menu (of pages) should show variants based on page language instead of site language
Language menu (of pages) should show variants based on page language instead ...
Status: NEW
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
: 66158 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-05 00:44 UTC by Liangent
Modified: 2014-11-17 11:06 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2014-06-05 00:44:24 UTC
Maybe the same issue as bug 66158.
Comment 1 Bingle 2014-06-05 00:45:19 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/2gdmj8Mz
Comment 2 Jon 2014-06-11 23:51:59 UTC
What does this bug mean? Could you add steps including URLS to replicate with expected behaviour?
Comment 3 Liangent 2014-06-12 05:33:04 UTC
Issue one:

URL: https://m.mediawiki.org/wiki/Bugzilla/zh#/languages

A variant list of Chinese is expected but it's not there.

Issue two:

URL: https://m.mediawiki.org/wiki/Special:MobileLanguages/Bugzilla/zh

A variant list is there but it's labeled as "English variants", not Chinese.
Comment 4 Jon 2014-06-12 16:48:59 UTC
Thanks Liagent, this is much clearer now :)
I think you are right and this is the same underlying problem as the other bug. Do you mind if we close the other bug 66158 to avoid fragmented conversations?
Comment 5 Liangent 2014-06-13 15:29:56 UTC
(In reply to Jon from comment #4)
> Do you mind if we close the other bug 66158 to avoid fragmented
> conversations?

Go for it
Comment 6 Jon 2014-06-13 15:38:02 UTC
*** Bug 66158 has been marked as a duplicate of this bug. ***
Comment 7 Jon 2014-06-13 18:12:03 UTC
Issue one:
This is generated by the API response from https://m.mediawiki.org/w/api.php?action=query&format=json&meta=siteinfo&siprop=general%7Clanguages&prop=langlinks&llurl=true&lllimit=max&titles=Bugzilla%2Fzh

I'm not sure why variants not included.. :-(

Issue two:
Looking into this, the titles simply use 'this->msg(' and I'm not sure how we can set the page content language on a special page.. :-/
Comment 8 Florian 2014-06-13 18:21:50 UTC
WIth issue two you mean https://bugzilla.wikimedia.org/show_bug.cgi?id=66591 ???

Then we can add statically to the msg( the text of the title object, or?
https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/specials/SpecialMobileLanguages.php#L132
Comment 9 Liangent 2014-06-13 18:24:47 UTC
(In reply to Florian from comment #8)
> WIth issue two you mean https://bugzilla.wikimedia.org/show_bug.cgi?id=66591
> ???
> 
> Then we can add statically to the msg( the text of the title object, or?
> https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/
> includes/specials/SpecialMobileLanguages.php#L132

No. On https://m.mediawiki.org/wiki/Special:MobileLanguages/Bugzilla/zh?uselang=en there is:

<h2 id="mw-mf-language-variant-header">English variants</h2>

which should be written as "Chinese variants".
Comment 10 Florian 2014-06-13 18:25:45 UTC
Ah, ok, sorry for misunderstanding! :)
Comment 11 Liangent 2014-06-13 18:29:46 UTC
(In reply to Jon from comment #7)
> Issue one:
> This is generated by the API response from
> https://m.mediawiki.org/w/api.
> php?action=query&format=json&meta=siteinfo&siprop=general%7Clanguages&prop=la
> nglinks&llurl=true&lllimit=max&titles=Bugzilla%2Fzh
> 
> I'm not sure why variants not included.. :-(

meta=siteinfo returns info about the site (so variants of the content language of that site), not about given titles...

I'm afraid there's no API emitting variants of a given title.
Comment 12 Liangent 2014-06-13 18:42:36 UTC
(In reply to Jon from comment #7)
> Issue two:
> Looking into this, the titles simply use 'this->msg(' and I'm not sure how
> we can set the page content language on a special page.. :-/

Okay so I had a look at that $this->msg() so there is issue three:

https://m.mediawiki.org/wiki/Special:MobileLanguages/Bugzilla/zh?uselang=zh-cn

This page says "English变体" instead of "英文变体". Without fixing this, it will say either "中文 variants" or "Chinese变体" after issue two is resolved.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links