Last modified: 2014-06-05 21:44:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68140, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 66140 - WikiCode de + not found+
WikiCode de + not found+
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Android App (Other open bugs)
Alpha
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-06-04 21:25 UTC by Bernd Sitzmann
Modified: 2014-06-05 21:44 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bernd Sitzmann 2014-06-04 21:25:05 UTC 
So far twice reported in OTRS. I haven't been able to reproduce this myself (switched device language to German) but it seems that there is an issue with the languages_list.xml table lookup.

The interesting part of the stack trace is:
~~~~
java.lang.RuntimeException: WikiCode de + not found+
at org.wikipedia.WikipediaApp.findWikiIndex(WikipediaApp.java:275)
at org.wikipedia.settings.LanguagePreference.<init>(LanguagePreference.java:26)

git SHA: 5df0d7b3
----

I think we should consider default to English instead of throwing a RuntimeException in this case.

From OTRS:
2014053010015204: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7580023
2014060410002588: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7587157
Comment 1 Bernd Sitzmann 2014-06-04 21:48:46 UTC 
Also got more reports from other German users in beta1. It was a build issue, which Yuvi fixed in beta2.
Comment 2 Yuvi Panda 2014-06-05 13:55:43 UTC 
This has been happening for some non de users as well, with weird language codes that we don't have. Updated code to not crash. We need to instrument this to figure out which language codes those are, but 'tis ok for now.
Comment 3 Gerrit Notification Bot 2014-06-05 13:56:04 UTC 
Change 137577 had a related patch set uploaded by Yuvipanda:
Don't crash if we can't find a language code

https://gerrit.wikimedia.org/r/137577
Comment 4 Gerrit Notification Bot 2014-06-05 13:57:35 UTC 
Change 137577 merged by Dbrant:
Don't crash if we can't find a language code

https://gerrit.wikimedia.org/r/137577
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links