Last modified: 2012-12-16 17:43:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T8612, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 6612 - Ajax code refactoring
Ajax code refactoring
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 43175
  Show dependency treegraph
 
Reported: 2006-07-09 23:30 UTC by Felipe Corrêa da Silva Sanches
Modified: 2012-12-16 17:43 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch that does this refactoring (19.51 KB, patch)
2006-07-09 23:55 UTC, Felipe Corrêa da Silva Sanches
Details

Description Felipe Corrêa da Silva Sanches 2006-07-09 23:30:01 UTC
I've been doing some little refactoring to the current ajax code. Since it is
intended to grow significantly as new features get developed, I decided to
remove the search feature specific portions of code from ajax.js and put it on a
new AjaxSearch.js file.

It is intended to have a new javascript file and config variable for each new
ajax feature developed in order to allow feature-specific control. All of these
variables default to true in order to still allow the use of $wgUseAjax for
global control.

All ajax files should be created at skins/common/ajax directory.
Comment 1 Felipe Corrêa da Silva Sanches 2006-07-09 23:55:20 UTC
Created attachment 2066 [details]
patch that does this refactoring
Comment 2 Felipe Corrêa da Silva Sanches 2006-07-17 06:35:07 UTC
this bug is closely related to bug 6593.
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-07-17 18:30:32 UTC
It's not a bug, ergo it's an enhancement.  Don't feel too bad if no one with
commit access is willing to look over a 300-line patch to make sure it's
bug-free and useful; it's only to be expected.  I would suggest you try spelling
out the reasons your patch is useful, and then just forget about it and move on
to other things.  There's really not enough manpower around here to allow all
patches to be reviewed, unfortunately.
Comment 4 Aaron Schulz 2008-08-03 19:20:15 UTC
Seems to have been cleaned up already.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links