Last modified: 2014-11-15 12:19:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67817, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 65817 - ZeroBanner should pass jshint
ZeroBanner should pass jshint
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ZeroBanner (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: jshint
  Show dependency tree / graph
 
Reported: 2014-05-27 16:52 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-11-15 12:19 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-05-27 16:52:15 UTC 
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Antoine "hashar" Musso (WMF) 2014-05-27 16:53:45 UTC 
NOTE the repository is a fork of mediawiki/extensions/ZeroRatedMobileAccess which has a similar bug: bug 61647.  Might want to fix the parent repository first.

See also Bug 65818 - ZeroPortal should pass jshint
Comment 2 Gerrit Notification Bot 2014-05-27 16:56:30 UTC 
Change 135586 had a related patch set uploaded by Hashar:
Trigger ZeroBanner and ZeroPortal jobs

https://gerrit.wikimedia.org/r/135586
Comment 3 Gerrit Notification Bot 2014-05-27 16:58:33 UTC 
Change 135586 merged by jenkins-bot:
Trigger ZeroBanner and ZeroPortal jobs

https://gerrit.wikimedia.org/r/135586
Comment 4 Andre Klapper 2014-10-17 11:48:04 UTC 
All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Comment 5 Andre Klapper 2014-11-15 12:19:44 UTC 
No reply to comment 4 - assuming this bug is FIXED.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links