Last modified: 2014-05-19 23:22:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67292, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65292 - VisualEditor: When editor is unavailable, edit menu item can re-appear
VisualEditor: When editor is unavailable, edit menu item can re-appear
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-05-22
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-14 16:52 UTC by WhatamIdoing
Modified: 2014-05-19 23:22 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description WhatamIdoing 2014-05-14 16:52:18 UTC
Steps to Reproduce:
1.  Open a Wikipedia article in the article namespace. 

2.  Resize the window to a very small size so that the buttons overlap to the next line. 

3.  Resize the window to the original size and see that the "Edit beta" button shows up, which was previously not there.

4.  Click on the new button to open VisualEditor.

Actual Results:  
Clicking the button produces an error message:

Error loading data from server: novenamespace: VisualEditor is not enabled in namespace 4. Would you like to retry?

Clicking OK closes this dialog, but immediately pops up another one of the same kind. 

Expected Results:  
That the button wouldn't ever be visible, and that if it were, that it wouldn't give an error message about namespace 4.

Reproducible: Didn't try
Comment 1 Krinkle 2014-05-14 17:32:57 UTC
Rephrasing bug title as bug is broader in scope.

The window resize bug is actually caused by a logic error in Vector in MediaWiki core (filed as bug 65294).

So it affects all browsers, and can bypass any soft restriction that we evaluate in javascript (browser support, namespace, content model, user preference etc.).

Because it's basically just always made to be visible regardless of why it was hidden, when doing the resize handle trick from minimum width back out.
Comment 2 Gerrit Notification Bot 2014-05-16 23:46:50 UTC
Change 133851 had a related patch set uploaded by Alex Monk:
Remove edit tab from the DOM if it's hidden

https://gerrit.wikimedia.org/r/133851
Comment 3 Gerrit Notification Bot 2014-05-19 17:51:15 UTC
Change 133851 merged by jenkins-bot:
Remove edit tab from the DOM if it's hidden

https://gerrit.wikimedia.org/r/133851

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links