Last modified: 2006-09-21 18:31:32 UTC
Some Mediawiki messages like [[MediaWiki:Lastmodified]] make use of a parameter containing date and time in the current locale to build messages like "This page was last modified 12:59, 2 July 2006". Some languages require additional words between date and time in the context of a full sentence and/or would put the date before the time ("This page was last modified on July 2, 2006 at 12:59"). So there should be separate parameters for date and time whereever a combined timestamp parameter occurs.
Do you really really need that? Can't you rephrase it using colon or similar?
Yes. This could be helpfull f.e. in German localisation.
(In reply to comment #1) > Do you really really need that? Can't you rephrase it using colon or similar? Is it really really too hard to fix? It would be a bit cryptic to write "last change: 12:59, license: GNU, privacy: yes, ..."
Not impossible but it isn't trivial nor high up in the priority list.
Assuming it is desirable to keep the parameter for the combined timestamp and just add one for time and date each, what is not trivial in changing $d = $wgLang->timeanddate( $timestamp, true ); $s = ' ' . wfMsg( 'lastmodified', $d ); to $td = $wgLang->timeanddate( $timestamp, true ); $t = $wgLang->time( $timestamp, true ); $d = $wgLang->date( $timestamp, true ); $s = ' ' . wfMsg( 'lastmodified', $td, $t, $d ); in function lastModified() in Skin.php and something similar for getAuthorCredits() in Credits.php?
Since there appears to be no more need for discussion please take the above as proposed patch. If it's not sufficient please tell what is missing.
I have updated 'lastmodified' in r16592.
(In reply to comment #7) > I have updated 'lastmodified' in r16592. I think that the message should be also renamed. Currently, if we don't run rebuildMessages.php, only the date is shown. Also, rebuildMessages.php won't help if the message is changed.
(In reply to comment #8) > I think that the message should be also renamed. Currently, if we don't run > rebuildMessages.php, only the date is shown. Also, rebuildMessages.php won't > help if the message is changed. OK - I will rename it.
Done in r16594.
... and r16595. Grrrrr...
