Last modified: 2006-09-21 18:31:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 6518 - Mediawiki messages need separate parameters for date and time
Mediawiki messages need separate parameters for date and time
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-07-02 19:05 UTC by Schnargel
Modified: 2006-09-21 18:31 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Schnargel 2006-07-02 19:05:58 UTC
Some Mediawiki messages like [[MediaWiki:Lastmodified]] make use of a parameter containing date and time in the current locale to build messages 
like "This page was last modified 12:59, 2 July 2006".

Some languages require additional words between date and time in the context of a full sentence and/or would put the date before the time ("This 
page was last modified on July 2, 2006 at 12:59"). So there should be separate parameters for date and time whereever a combined timestamp 
parameter occurs.
Comment 1 Niklas Laxström 2006-07-02 19:12:22 UTC
Do you really really need that? Can't you rephrase it using colon or similar?
Comment 2 Jimmy Collins 2006-07-02 19:15:52 UTC
Yes. This could be helpfull f.e. in German localisation.
Comment 3 Schnargel 2006-07-02 19:29:11 UTC
(In reply to comment #1)
> Do you really really need that? Can't you rephrase it using colon or similar?

Is it really really too hard to fix? It would be a bit cryptic to write "last change: 12:59, license: GNU, privacy: yes, ..."

Comment 4 Niklas Laxström 2006-07-02 19:37:20 UTC
Not impossible but it isn't trivial nor high up in the priority list.
Comment 5 Schnargel 2006-07-03 17:19:09 UTC
Assuming it is desirable to keep the parameter for the combined timestamp and just add one for time and date each, what is not trivial in 
changing

    $d = $wgLang->timeanddate( $timestamp, true );
    $s = ' ' . wfMsg( 'lastmodified', $d );
to
    $td = $wgLang->timeanddate( $timestamp, true );
    $t = $wgLang->time( $timestamp, true );
    $d = $wgLang->date( $timestamp, true );
    $s = ' ' . wfMsg( 'lastmodified', $td, $t, $d );

in function lastModified() in Skin.php and something similar for getAuthorCredits() in Credits.php?
Comment 6 Schnargel 2006-07-22 23:27:19 UTC
Since there appears to be no more need for discussion please take the above as proposed patch. If it's not sufficient please tell what is 
missing.
Comment 7 Jimmy Collins 2006-09-21 16:49:05 UTC
I have updated 'lastmodified' in r16592.
Comment 8 Rotem Liss 2006-09-21 16:56:22 UTC
(In reply to comment #7)
> I have updated 'lastmodified' in r16592.

I think that the message should be also renamed. Currently, if we don't run
rebuildMessages.php, only the date is shown. Also, rebuildMessages.php won't
help if the message is changed.
Comment 9 Jimmy Collins 2006-09-21 17:59:17 UTC
(In reply to comment #8)
> I think that the message should be also renamed. Currently, if we don't run
> rebuildMessages.php, only the date is shown. Also, rebuildMessages.php won't
> help if the message is changed.

OK - I will rename it.
Comment 10 Jimmy Collins 2006-09-21 18:28:16 UTC
Done in r16594.
Comment 11 Jimmy Collins 2006-09-21 18:31:32 UTC
... and r16595. Grrrrr...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links