Last modified: 2014-09-30 23:02:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67059, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65059 - OOjs UI: PopupToolGroup shows horizontal scrollbar, tools are not wide enough to contain labels
OOjs UI: PopupToolGroup shows horizontal scrollbar, tools are not wide enough...
Status: RESOLVED FIXED
Product: OOjs UI
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-09 10:42 UTC by Roan Kattouw
Modified: 2014-09-30 23:02 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (10.36 KB, image/png)
2014-05-09 10:42 UTC, Roan Kattouw
Details
IE11 screenshots (45.32 KB, image/png)
2014-09-29 15:18 UTC, Bartosz Dziewoński
Details

Description Roan Kattouw 2014-05-09 10:42:54 UTC
Created attachment 15324 [details]
Screenshot

It looks like PopupToolgroup isn't taking the widths of the tool labels into account quite correctly. This seems to be causing the horizontal scrollbar in the attached screenshot.

Also note that when you hover over "Special characters", the box that appears on hover doesn't contain all of the text and ends about halfway through the 'e'.
Comment 1 Bartosz Dziewoński 2014-09-29 14:38:37 UTC
This only happens when the vertical scrollbar is needed to display all items.
Comment 2 Bartosz Dziewoński 2014-09-29 15:18:29 UTC
It also doesn't happen on IE 11. Opera latest, Firefox latest and Opera 12 all exhibit the issue.

I can't tell if this is a very wide-spread browser bug (with IE being the only browser to get this right), or counter-intuitive yet correct according to the specification behavior that IE implements differently. Either way we'll probably want to file at least one upstream bug ;)

Basically, the PopupToolGroup in the toolbar has no explicit width set. When we apply explicit height and overflow-y: auto (via ClippableElement), the browser needs to render a scrollbar.

The expected behavior would be to extend the element's width by the width of scrollbar. Browsers (except IE) instead keep the width and insert the vertical scrollbar inside, which causes them to also need to insert horizontal scrollbar.

Changing 'overflow-y: auto' to 'scroll' fixes the issue in all browsers.
Comment 3 Bartosz Dziewoński 2014-09-29 15:18:58 UTC
Created attachment 16621 [details]
IE11 screenshots
Comment 4 Gerrit Notification Bot 2014-09-29 15:32:27 UTC
Change 163586 had a related patch set uploaded by Bartosz Dziewoński:
ClippableElement: Use 'overflow-[xy]: scroll' rather than 'auto'

https://gerrit.wikimedia.org/r/163586
Comment 5 Bartosz Dziewoński 2014-09-29 15:39:39 UTC
JSFiddle: http://jsfiddle.net/hxyxvqy0/
Comment 6 Bartosz Dziewoński 2014-09-29 15:44:07 UTC
(As a curiosity, Opera 12 only exhibits the issue only if the dropdown contains block elements that contain inline-block elements. Not that anyone cares ;) )
Comment 7 Gerrit Notification Bot 2014-09-30 22:43:02 UTC
Change 163586 merged by jenkins-bot:
ClippableElement: Use 'overflow-[xy]: scroll' rather than 'auto'

https://gerrit.wikimedia.org/r/163586

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links