Last modified: 2007-01-02 06:03:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 6503 - CSS IDs in MonoBook.php and commonPrint.css don't match
CSS IDs in MonoBook.php and commonPrint.css don't match
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.9.x
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-06-30 22:05 UTC by Schnargel
Modified: 2007-01-02 06:03 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Change id in commonPrint.css (446 bytes, patch)
2006-12-28 15:06 UTC, Li-sung
Details
Patch adding f- so id match with commonPrint.css (448 bytes, patch)
2006-12-29 19:17 UTC, Li-sung
Details

Description Schnargel 2006-06-30 22:05:00 UTC
Earlier the elements of the list in the page footer in skins/MonoBook.php were tagged with CSS IDs like "f-disclaimer". Sometime the "f-" got lost. 
Now hiding of links in skins/common/commonPrint.css by refering to the no longer existing "f-" IDs does not work.
Comment 1 Schnargel 2006-07-22 23:06:30 UTC
It appears it happened in the change to revision 12212 of skins/MonoBook.php

Now changing line 260 from

?>                <li id="<?=$aLink?>"><?= $this->html($aLink) ?></li>

to

?>                <li id="f-<?=$aLink?>"><?= $this->html($aLink) ?></li>

should fix this.
Comment 2 Schnargel 2006-10-04 18:23:19 UTC
Meanwhile it's changing

?>                <li id="<?php echo$aLink?>"><?php $this->html($aLink) ?></li>

to

?>                <li id="f-<?php echo$aLink?>"><?php $this->html($aLink) ?></li>

Comment 3 Li-sung 2006-12-28 15:06:12 UTC
Created attachment 2969 [details]
Change id in commonPrint.css 

This patch should change id in commonPrint.css, so that it match with right id
in use
Comment 4 Schnargel 2006-12-29 18:33:32 UTC
I would have patched that other single line since that does fix what most likely was forgotten in the above mentioned change to r12212 *and* 
it would keep the "f-" in all "f"ooter IDs making the style sheet easier to read.
However the other way should work too.
Comment 5 Li-sung 2006-12-29 19:17:54 UTC
Created attachment 2980 [details]
Patch adding f- so id match with commonPrint.css

Choose only one patch
Comment 6 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-01-02 05:34:07 UTC
I picked the patch from comment #3 because a) people may have customized CSS/JS
based on the current id and b) the equivalent links might not actually be in a
footer in other skins.
Comment 7 Schnargel 2007-01-02 06:03:31 UTC
Monobook IDs won't appear in Cologne Blue ... and if it takes few over six months to fix two forgotten letters the thought to consider the 
buggy names as established has something.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links