Last modified: 2014-05-06 21:48:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66948, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 64948 - fatal: Not a git repository: '/home/travis/build/wikimedia/mediawiki-core/testMissingJsonData/.git' on travis
fatal: Not a git repository: '/home/travis/build/wikimedia/mediawiki-core/tes...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
1.24rc
All All
: Normal minor (vote)
: ---
Assigned To: Bryan Davis
: code-update-regression
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-05-06 09:43 UTC by Addshore
Modified: 2014-05-06 21:48 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Addshore 2014-05-06 09:43:33 UTC 
Since https://gerrit.wikimedia.org/r/#/c/130498 was merged travis outputs a fatal error in the middle of tests

fatal: Not a git repository: '/home/travis/build/wikimedia/mediawiki-core/testMissingJsonData/.git'

Before this was merged:
https://travis-ci.org/wikimedia/mediawiki-core/jobs/24496055#L124

After this was merged:
https://travis-ci.org/wikimedia/mediawiki-core/jobs/24496592#L124
Comment 1 Bryan Davis 2014-05-06 15:24:19 UTC 
This error is raised in GitInfoTest::testMissingJsonData() negative test by GitInfo::getHeadCommitDate(). getHeadCommitDate execs `git show ...` to find the date of the current HEAD without ever checking that GitInfo::basedir exists and valid. It looks like the rest of the data accessors in GitInfo do an is_readable() check and quietly return false if the git control files aren't available.
Comment 2 Gerrit Notification Bot 2014-05-06 19:20:15 UTC 
Change 131764 had a related patch set uploaded by BryanDavis:
Check for valid git repository in GitInfo::getHeadCommitDate

https://gerrit.wikimedia.org/r/131764
Comment 3 Gerrit Notification Bot 2014-05-06 20:00:44 UTC 
Change 131764 merged by jenkins-bot:
Check for valid git repository in GitInfo::getHeadCommitDate

https://gerrit.wikimedia.org/r/131764
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links