Last modified: 2014-04-29 14:10:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66057, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64057 - Using incorrect array parameter syntax does not raise an error/warning
Using incorrect array parameter syntax does not raise an error/warning
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.23.0
All All
: Normal normal (vote)
: ---
Assigned To: Brad Jorsch
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-17 14:27 UTC by Brad Jorsch
Modified: 2014-04-29 14:10 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 Gerrit Notification Bot 2014-04-17 14:28:15 UTC
Change 126990 had a related patch set uploaded by Anomie:
API: Warn when unsupported PHP array syntax is used

https://gerrit.wikimedia.org/r/126990
Comment 2 Tisza Gergő 2014-04-27 05:53:06 UTC
These URLs are produced by mw.Api when as array is passed as argument:

new mw.Api().get( { action: 'query', prop: 'globalusage', titles: 'File: Swallow flying drinking.jpg', guprop: ['url', 'namespace'], gufilterlocal: 1} );

as opposed to

new mw.Api().get( { action: 'query', prop: 'globalusage', titles: 'File: Swallow flying drinking.jpg', guprop: 'url|namespace', gufilterlocal: 1} );

Not sure if this is a bug or a feature, but it is very counterintuitive.
Comment 3 Brad Jorsch 2014-04-28 14:26:28 UTC
(In reply to Tisza Gergő from comment #2)
> These URLs are produced by mw.Api when as array is passed as argument:
[...]
> Not sure if this is a bug or a feature, but it is very counterintuitive.

If it's a bug, it should be filed as a separate bug against the JavaScript component. You might refer to bug 10262 when doing so.
Comment 4 Gerrit Notification Bot 2014-04-29 03:30:13 UTC
Change 126990 merged by jenkins-bot:
API: Warn when unsupported PHP array syntax is used

https://gerrit.wikimedia.org/r/126990
Comment 5 Brad Jorsch 2014-04-29 14:10:48 UTC
Should be deployed to WMF wikis with 1.24wmf3, see https://www.mediawiki.org/wiki/MediaWiki_1.24/Roadmap for the schedule.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links