Last modified: 2006-06-22 01:41:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T8392, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 6392 - Leading <br /> in [[Special:Preferences]]


Summary:	Leading <br /> in [[Special:Preferences]]

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Special pages (Other open bugs)
Version:	1.7.x
Hardware:	All All

Importance:	Normal minor with 2 votes (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	http://en.wikipedia.org/wiki/Special:...
Whiteboard:
Keywords:	patch, patch-reviewed

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-06-21 14:50 UTC by Tom Preuss
Modified:	2006-06-22 01:41 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
adds a variable that enables the '<br />' to only display if both $wgAllowRealName and $wgEnableEmail are set to true (691 bytes, patch) 2006-06-21 15:35 UTC, Ben White	Details
Add an attachment (proposed patch, testcase, etc.)

Description Tom Preuss 2006-06-21 14:50:30 UTC

From includes/SpecialPreferences.php, lines 694-701:

        if ($wgAllowRealName || $wgEnableEmail) {
            $wgOut->addHTML("<div class='prefsectiontip'>");
            $rn = $wgAllowRealName ? wfMsg('prefs-help-realname') : '';
            $em = $wgEnableEmail ? '<br />' .  wfMsg('prefs-help-email') : '';
            $wgOut->addHTML( $rn . $em  . '</div>');
        }

When $wgAllowRealName is set to false and $wgEnableEmail is set to true, as it
is on (at least to my knowledge) the English Wikipedia and (I know for a fact)
on the Homestar Runner wiki (http://hrwiki.org), the leading <br /> makes the
pink prefsectiontip div look odd.

This occurs in both 1.6.7 and 1.7-svn.

Comment 1 Ben White 2006-06-21 15:35:02 UTC

Created attachment 1997 [details]
adds a variable that enables the '<br />' to only display if both $wgAllowRealName and $wgEnableEmail are set to true

This patch fixes both REL1_6 and 1.7-svn.

Comment 2 Tom Preuss 2006-06-21 15:39:48 UTC

Patch tested and confirmed to work on both 1.6.7 and 1.7-svn.

Comment 3 Rob Church 2006-06-22 01:41:19 UTC

Fixed in SVN trunk, r14894. Didn't use the supplied patch, but thanks.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links