Last modified: 2006-06-22 01:41:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 6392 - Leading <br /> in [[Special:Preferences]]
Leading <br /> in [[Special:Preferences]]
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.7.x
All All
: Normal minor with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/Special:...
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-06-21 14:50 UTC by Tom Preuss
Modified: 2006-06-22 01:41 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
adds a variable that enables the '<br />' to only display if both $wgAllowRealName and $wgEnableEmail are set to true (691 bytes, patch)
2006-06-21 15:35 UTC, Ben White
Details

Description Tom Preuss 2006-06-21 14:50:30 UTC
From includes/SpecialPreferences.php, lines 694-701:

        if ($wgAllowRealName || $wgEnableEmail) {
            $wgOut->addHTML("<div class='prefsectiontip'>");
            $rn = $wgAllowRealName ? wfMsg('prefs-help-realname') : '';
            $em = $wgEnableEmail ? '<br />' .  wfMsg('prefs-help-email') : '';
            $wgOut->addHTML( $rn . $em  . '</div>');
        }

When $wgAllowRealName is set to false and $wgEnableEmail is set to true, as it
is on (at least to my knowledge) the English Wikipedia and (I know for a fact)
on the Homestar Runner wiki (http://hrwiki.org), the leading <br /> makes the
pink prefsectiontip div look odd.

This occurs in both 1.6.7 and 1.7-svn.
Comment 1 Ben White 2006-06-21 15:35:02 UTC
Created attachment 1997 [details]
adds a variable that enables the '<br />' to only display if both $wgAllowRealName and $wgEnableEmail are set to true

This patch fixes both REL1_6 and 1.7-svn.
Comment 2 Tom Preuss 2006-06-21 15:39:48 UTC
Patch tested and confirmed to work on both 1.6.7 and 1.7-svn.
Comment 3 Rob Church 2006-06-22 01:41:19 UTC
Fixed in SVN trunk, r14894. Didn't use the supplied patch, but thanks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links