Last modified: 2014-04-17 14:48:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65873, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 63873 - Upgrade to Moment.js 2.6.0


Summary:	Upgrade to Moment.js 2.6.0

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	JavaScript (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal enhancement (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	https://github.com/moment/moment/pull...
Whiteboard:
Keywords:	i18n

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-04-13 07:42 UTC by Minh Nguyễn
Modified:	2014-04-17 14:48 UTC (History)
CC List:	17 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Minh Nguyễn 2014-04-13 07:42:35 UTC

Please upgrade Moment.js to version 2.6.0, which has many bug fixes and several new features. In particular, Moment.js was using an incorrect language code for Vietnamese (vn instead of vi); upgrading should fix the issue in which Hovercards were showing timestamps like “Sửa đổi lần cuối 9 days ago”.

As a side note, it needs to be easier for MediaWiki’s very thorough translators to find out that timestamps are being translated in an obscure third-party project on GitHub.

Comment 1 Nemo 2014-04-13 17:26:11 UTC

(In reply to Minh Nguyễn from comment #0)
> As a side note, it needs to be easier for MediaWiki’s very thorough
> translators to find out that timestamps are being translated in an obscure
> third-party project on GitHub.

Ugh. Yet another one? :< Please file a separate bug for that.

Comment 2 Quiddity 2014-04-15 22:29:31 UTC

(In reply to Nemo from comment #1)
> (In reply to Minh Nguyễn from comment #0)
> > As a side note, it needs to be easier for MediaWiki’s very thorough
> > translators to find out that timestamps are being translated in an obscure
> > third-party project on GitHub.
> 
> Ugh. Yet another one? :< Please file a separate bug for that.

Prateek, you may want to see [[mw:Extension:CLDR]] - I believe that's what everything else in MediaWiki uses, for timestamps. (Obligatory IANAD disclaimer :)

Comment 3 Yuvi Panda 2014-04-15 22:31:41 UTC

moment.js is part of core, so changing component.

Comment 4 Yuvi Panda 2014-04-15 22:32:23 UTC

(In reply to Quiddity from comment #2)
> Prateek, you may want to see [[mw:Extension:CLDR]] - I believe that's what
> everything else in MediaWiki uses, for timestamps. (Obligatory IANAD
> disclaimer :)

Sadly there is no way to access CLDR in JS, so moment.js was merged to make up for that.

Comment 5 Tisza Gergő 2014-04-15 23:05:42 UTC

Changelog for 2.6.0 is at https://gist.github.com/ichernev/10544682 , none of it seems to be a breaking change.

Comment 6 Gerrit Notification Bot 2014-04-16 12:58:15 UTC

Change 126236 had a related patch set uploaded by Prtksxna:
Update moment.js to 2.6.0

https://gerrit.wikimedia.org/r/126236

Comment 7 Gerrit Notification Bot 2014-04-16 14:07:51 UTC

Change 126236 had a related patch set uploaded by Siebrand:
Update moment.js to 2.6.0

https://gerrit.wikimedia.org/r/126236

Comment 8 Gerrit Notification Bot 2014-04-17 14:47:09 UTC

Change 126236 merged by jenkins-bot:
Update moment.js to 2.6.0

https://gerrit.wikimedia.org/r/126236

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links