Last modified: 2014-11-04 20:39:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65840, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63840 - OOjs UI: Selected text in readonly/disabled TextInputWidget is hard to read on Chrome on Linux
OOjs UI: Selected text in readonly/disabled TextInputWidget is hard to read o...
Status: RESOLVED FIXED
Product: OOjs UI
Classification: Unclassified
General (Other open bugs)
unspecified
PC Linux
: Normal trivial
: ---
Assigned To: Sucheta Ghoshal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-11 23:04 UTC by Tisza Gergő
Modified: 2014-11-04 20:39 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
TextInputWidget with selected text, default look (18.71 KB, image/png)
2014-04-11 23:05 UTC, Tisza Gergő
Details
TextInputWidget with selected text, with text-shadow disabled (12.84 KB, image/png)
2014-04-11 23:05 UTC, Tisza Gergő
Details

Description Tisza Gergő 2014-04-11 23:04:41 UTC
OOjs UI adds a white text shadow to the TextInputWidget. This is normally invisible (since it's on a white background) but looks very ugly on Chrome on Linux when the text is selected, since selected text has white color and the shadow distorts the characters. Seen on Chrome 33 on Ubuntu 13.10, in the Use this file > Embed > HTML menu in MediaViewer.
Comment 1 Tisza Gergő 2014-04-11 23:05:33 UTC
Created attachment 15086 [details]
TextInputWidget with selected text, default look
Comment 2 Tisza Gergő 2014-04-11 23:05:57 UTC
Created attachment 15087 [details]
TextInputWidget with selected text, with text-shadow disabled
Comment 3 Roan Kattouw 2014-10-24 06:27:45 UTC
I got confused for a bit trying to reproduce this. Turns out it only happens for readonly and disabled TextInputWidgets.
Comment 4 Roan Kattouw 2014-10-24 18:42:52 UTC
So I had a chat with Trevor and we decided that the text shadow should be removed for readonly TextInputWidgets (like the examples in your screenshot). It makes no sense because it's a white shadow on a white background anyway, so you can't even see it unless you're selecting.

For disabled TextInputWidgets, we do want to keep the white shadow to make the gray text on a gray background stand out. We considered unsetting the shadow when selecting, but selection of text in a disabled input 1) sounds like it shouldn't be possible, 2) doesn't appear to be detectable and 3) is implemented inconsistently in browsers (I played with it in Firefox and it was HAUNTED)
Comment 5 Gerrit Notification Bot 2014-11-04 20:26:12 UTC
Change 171030 had a related patch set uploaded by SuchetaG:
Removing text-shadow from readonly/disabled text in TextInputWidget

https://gerrit.wikimedia.org/r/171030
Comment 6 Gerrit Notification Bot 2014-11-04 20:39:53 UTC
Change 171030 merged by jenkins-bot:
Removing text-shadow from readonly/disabled text in TextInputWidget

https://gerrit.wikimedia.org/r/171030

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links