Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T8358, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 6358 - SpecialAllpages.php - redundant variables

Summary:	SpecialAllpages.php - redundant variables

Status: RESOLVED FIXED Product: MediaWiki Classification: Unclassified Component: Special pages (Other open bugs) Version: unspecified Hardware: PC Windows XP Importance: Low enhancement (vote) Target Milestone: --- Assigned To: Nobody - You can work on this! URL: Whiteboard: Keywords: Depends on: Blocks:   Show dependency tree / graph		Reported: 2006-06-18 13:32 UTC by Shtriter Andrew Modified: 2006-07-07 11:12 UTC (History) CC List: 0 users See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Shtriter Andrew 2006-06-18 13:32:28 UTC $page $fromwhere $order_arr and $order_str variables are defined in SpecialAllpages.php (lines 93-96) but not used. Special:Allpages works fine when they are deleted. Comment 1 Shtriter Andrew 2006-06-18 13:36:27 UTC Possible reason is the use of $dbr->selectField(...) function. So I guess that these vars were forgotten when new DB access approach was introduced. Comment 2 Rotem Liss 2006-07-07 11:12:07 UTC r15405.