Last modified: 2005-01-12 23:45:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T2634, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 634 - Logo can flicker in IE
Logo can flicker in IE
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
PC Windows XP
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks: 640
  Show dependency treegraph
 
Reported: 2004-10-03 01:03 UTC by Tom Gilder
Modified: 2005-01-12 23:45 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Old patch for logo flicker (1.57 KB, patch)
2004-10-03 01:51 UTC, Tom Gilder
Details
Patch for logo flicker v2 (2.37 KB, patch)
2004-10-06 20:02 UTC, Tom Gilder
Details
Patch for logo flicker v2.1 (2.44 KB, patch)
2004-10-06 20:14 UTC, Tom Gilder
Details

Description Tom Gilder 2004-10-03 01:03:34 UTC
Sometimes when you move your mouse over the main page logo, IE sends a HTTP request for it and flickers 
the image whilst doing so. 

Primarily this occurs when the logo URL redirects to the actual image (as currently happens on some 
Wikimedia projects), but I've seen it happen previously under other circumstances, so it's best to make 
sure this can never happen.

Simply applying the logo image to any element than <a> fixes it, so...


Change /templates/xhtml_slim.pt, line 59 to:

  <div class="portlet" id="p-logo">
    <a href="${nav_urls/mainpage/href}" i18n:attributes="title string:mainpage"><span style="background-
image: url(${logopath});"></span></a>
  </div>

And then update /stylesheets/monobook/main.css, line 601 (replace #p-logo a, #p-logo a:hover):

#p-logo a {
    text-decoration: none;
}
#p-logo a span {
    display: block;
    height: 155px;
    width: 12.2em;
    background-repeat: no-repeat;
    background-position: 35% 50% !important;
}
Comment 1 Tom Gilder 2004-10-03 01:51:22 UTC
Created attachment 62 [details]
Old patch for logo flicker
Comment 2 Tom Gilder 2004-10-06 20:02:54 UTC
Created attachment 70 [details]
Patch for logo flicker v2

After much mucking around, I decided to make this a script-only fix (much the
easiest way). This patch for IEFixes.js fixes quite a few problems with the
logo in IE5.5+, and only affects IE5.5+.
Comment 3 Tom Gilder 2004-10-06 20:14:38 UTC
Created attachment 71 [details]
Patch for logo flicker v2.1

Makes sure the document is never transformed more than once.
Comment 4 JeLuF 2004-10-06 20:27:34 UTC
Applied in skins/common/IEFixes.js, rev 1.3
Comment 5 Angela 2004-11-05 10:19:17 UTC
This seems to be fixed in the Wikipedias, but I've had a report on my talk page
that it is not fixed for the Wikiquotes:

:In the projects wikiquote (in all the languages) happens the following one:
when passing mouse in top of logo, logo is blinking. This does not happen in the
other projects (wikipedia, wikitionary). What to make so that soon of wikiquote
it is not blinking when passing mouse?
http://pt.wikiquote.org/wiki/Usu%C3%A1rio:Chico
Comment 6 Steve 2004-11-05 22:04:41 UTC
It is my opinion that the logo shouldn't be a background image at all,
especially considering that the page itself already has a background.  Far
better to make it a linked image:
<pre>
<div class="portlet" id="p-logo">
<a href="${nav_urls/mainpage/href}" i18n:attributes="title string:mainpage"><img
alt="Logo" border="0" src="${logopath}"></a>
</div>
</pre>

Not only should this fix the problem, it's much better html code.
Comment 7 Tom Gilder 2005-01-12 23:45:56 UTC
This should now be fixed everywhere.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links