Last modified: 2014-04-25 05:40:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65310, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63310 - Callers of ResourceLoader::getModule should check for null return values
Callers of ResourceLoader::getModule should check for null return values
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.23.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-31 17:36 UTC by Ori Livneh
Modified: 2014-04-25 05:40 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ori Livneh 2014-03-31 17:36:41 UTC 
As a rule, callers of ResourceLoader::getModule() in includes/resourceloader/ResourceLoader.php do not guard against a null return value, and simply assume it is a ResourceLoaderModule object.

Exceptions on attempts to call methods on non-objects are the current (superficial) cause of missing CSS / JS on <http://en.hhvm.beta.wmflabs.org/wiki/Main_Page>. The deeper cause is probably that en.hhvm.beta.wmflabs.org and en.wikipedia.beta.wmflabs.org share the same DB but load a different set of extensions. Regardless, if it is possible for ResourceLoader::getModule to return null, callers should check for it and react appropriately.
Comment 1 Gerrit Notification Bot 2014-04-04 00:22:29 UTC 
Change 123802 had a related patch set uploaded by Ori.livneh:
Callers of ResourceLoader::getModule should check for null return

https://gerrit.wikimedia.org/r/123802
Comment 2 Gerrit Notification Bot 2014-04-04 00:54:56 UTC 
Change 123802 merged by jenkins-bot:
Callers of ResourceLoader::getModule should check for null return

https://gerrit.wikimedia.org/r/123802
Comment 3 Aaron Schulz 2014-04-09 18:29:57 UTC 
Can this be closed?
Comment 4 Andre Klapper 2014-04-25 05:24:51 UTC 
Ori: Patch was merged a while ago - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links