Last modified: 2006-06-12 02:26:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 6275 - non-breaking space doesnt work in charinsert
non-breaking space doesnt work in charinsert
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CharInsert (Other open bugs)
unspecified
PC Windows XP
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-06-11 15:02 UTC by Tisza Gergő
Modified: 2006-06-12 02:26 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tisza Gergő 2006-06-11 15:02:48 UTC
<charinsert>&nbsp;</charinsert> inserts a normal space instead of a non-breaking
one.

Best way to fix would be inserting &nbsp; (not the non-breaking space character
itself) so that page code remains easy to understand.
Comment 1 Brion Vibber 2006-06-11 20:33:11 UTC
1) What doesn't work about it?
2) Where doesn't it work?
3) Is this your site or a Wikimedia site?
4) What is the exact URL to the page where you encounter this 
behavior?
5) What web browser, of what version, on what operating system, 
are you using?
Comment 2 Tisza Gergő 2006-06-11 21:08:10 UTC
It should insert &nbsp; when clicked; it inserts a normal space character
instead. Tested under Firefox v1.06 Moox on Windows XP and Firefox 1.0 on Win98.

I didnt realize it might be a browser problem, but now I tested with IE6 and it
works fine; the HTML cource code also seems to be in order (<a
onclick="insertTags('&amp;nbsp;','','');return false" href="#">&amp;nbsp;</a>).
Anyway, the site is the hungarian Wikipedia (you can test it at the
[http://hu.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:Homokoz%C3%B3&action=edit
Sandbox]), and the charinsert code is in [[Wikipédia:Edittools]] which is
included as a template into [[MediaWiki:Edittools]] (to avoid the bug with
templates expanding in charinsert).
Comment 3 Tisza Gergő 2006-06-11 21:09:52 UTC
Sorry, that should be [[hu:Wikipédia:Edittools]] and [[hu:MediaWiki:Edittools]].
Comment 4 Brion Vibber 2006-06-12 02:26:30 UTC
This appears to be caused by the JavaScript in 
MediaWiki:Monobook.js: The use of innerHTML to add a menu 
triggers a bug in Firefox and Safari which damages some of 
the characters.

I've changed it to use DOM functions, which add the menu 
without damaging the existing items. Bugs will need to be 
filed with Mozilla and Apple if they're not already there.

The JS fix:
http://hu.wikipedia.org/w/index.php?
title=MediaWiki:Monobook.js&diff=642767&oldid=497575

Note that you may need to clear your cache to see the 
corrected version live.


Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links