Last modified: 2014-03-14 02:32:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64609, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62609 - VisualEditor: MediaWiki <source> used between text nodes should render block instead of inline-block
VisualEditor: MediaWiki <source> used between text nodes should render block...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-13 18:23 UTC by Krinkle
Modified: 2014-03-14 02:32 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of MediaWiki rendering (34.58 KB, image/png)
2014-03-13 18:23 UTC, Krinkle
Details
Screenshot of VisualEditor rendering (44.30 KB, image/png)
2014-03-13 18:24 UTC, Krinkle
Details
Screenshot of Parsoid rendering and Parsoid DOM (262.38 KB, image/png)
2014-03-13 18:24 UTC, Krinkle
Details

Description Krinkle 2014-03-13 18:23:53 UTC
Created attachment 14803 [details]
Screenshot of MediaWiki rendering

Wikitext:

=== Example ===
Foo <code>bar</code> baz.
You'll want to add <source lang="javascript">
        "predef": [
                "OO",
        ]
</source> x y.


In MediaWiki's PHP parser:

  <h3>..</h3>
  <p>Foo <code>bar</code> baz.</p>
  <p>You'll want to add</p>
  <div> .. syntax highlgiht ..
  <p>x y.</p>

In Parsoid:

  <h3>..</h3>
  <p>Foo <code>bar</code> baz.</p>
  You'll want to add
  <div> .. syntax highlgiht ..
  x y.

Notice the lack of paragraphs from the Parsoid DOM, though this is odd, it still renders fine visually in browsers.

In VisualEditor:

  <h3 class="ve-ce-branchNode">Naming</h3>
  <p class="ve-ce-generated-wrapper ve-ce-branchNode">
    You'll want to add&nbsp;
    <span class="ve-ce-leafNode ve-ce-generatedContentNode ve-ce-mwExtensionNode ve-ce-mwAlienExtensionNode ve-ce-protectedNode" contenteditable="false">
      <div dir="ltr" class="mw-geshi mw-code mw-content-ltr" typeof="mw:Extension/source" data-mw=".." about="#mwt24">..</div>
    </span>
    &nbsp;x y.
  </p>

It renders as an inline-block within a paragraph, that's where it goes wrong.
Comment 1 Krinkle 2014-03-13 18:24:12 UTC
Created attachment 14804 [details]
Screenshot of VisualEditor rendering
Comment 2 Krinkle 2014-03-13 18:24:28 UTC
Created attachment 14805 [details]
Screenshot of Parsoid rendering and Parsoid DOM

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links