Last modified: 2007-07-31 11:08:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 6253 - Use of {{DISPLAYTITLE|xyz}} renders blank title (<title></title>)
Use of {{DISPLAYTITLE|xyz}} renders blank title (<title></title>)
Status: VERIFIED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.7.x
PC Linux
: Normal normal with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-06-09 16:06 UTC by Jelte (WebBoy)
Modified: 2007-07-31 11:08 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to fix bug 6253 (1.23 KB, patch)
2007-05-05 11:21 UTC, Jelte (WebBoy)
Details

Description Jelte (WebBoy) 2006-06-09 16:06:35 UTC
When using {{DISPLAYTITLE|xyz}}, <h1>Main Page</h1> becomes <h1>xyz</h1>, but
<title>Main Page - TestWiki</title> becomes <title></title>
Comment 1 Brion Vibber 2006-06-09 20:45:25 UTC
DISPLAYTITLE is fatally broken and will likely be removed or 
rewritten.
Comment 2 Omegatron 2006-12-21 17:05:01 UTC
(In reply to comment #1)
> DISPLAYTITLE is fatally broken and will likely be removed or 
> rewritten.

Rewritten, please.  It's sorely needed.  

There are now javascript hacks in Common.js to implement the same functionality,
but it would be better if it were done in Mediawiki itself.
Comment 3 Jelte (WebBoy) 2007-05-05 11:21:11 UTC
Created attachment 3580 [details]
Patch to fix bug 6253

In this patch I:
* Removed parsing of the given title, since the title is always escaped.
* Hid the text "(Link to this page as $1)" when the given title equals the real
title
* Altered OutputPage::addParserOutputNoText() to set both $mPagetitle (<h1>)
and $mHTMLtitle (<title>) (actual fix)

Both OutputPage::$mPageLinkTitle and $this->data['displaytitle'] (MonoBook.php)
are not used before and after this patch and should probably be removed.
Comment 4 Rob Church 2007-07-15 12:14:04 UTC
Fixed back in r23393.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links