Last modified: 2014-03-14 20:01:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64088, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62088 - VisualEditor: Undoing creation of empty heading places cursor at invalid offset
VisualEditor: Undoing creation of empty heading places cursor at invalid offset
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-03-06
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-01 01:22 UTC by Rummana Yasmeen
Modified: 2014-03-14 20:01 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (123.25 KB, image/png)
2014-03-01 01:22 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-03-01 01:22:18 UTC
Created attachment 14724 [details]
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Create a heading
3.Undo creating the heading and type something in that line instead
4.Press enter

Observed Result:
Uncaught Error: Inserted data is trying to close the root node (at index 0) is appearing in the console.

See the screenshot attached

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Test62015&veaction=edit
Comment 1 Ed Sanders 2014-03-04 15:16:16 UTC
In standalone demo empty.html

1. Turn on 'get range on change', observe [1,1]
2. Create heading, observe [1,1]
3. Undo, observe [2,2]

Expected: Range is still [1,1] after undo
Comment 2 Gerrit Notification Bot 2014-03-04 16:25:56 UTC
Change 116754 had a related patch set uploaded by Esanders:
Use previous breakpoint's range when undoing

https://gerrit.wikimedia.org/r/116754
Comment 3 Gerrit Notification Bot 2014-03-05 19:54:42 UTC
Change 116754 merged by jenkins-bot:
Store previous range in breakpoint for undo

https://gerrit.wikimedia.org/r/116754
Comment 4 Rummana Yasmeen 2014-03-06 01:11:09 UTC
Verified the fix in Betalabs
Comment 5 Rummana Yasmeen 2014-03-07 00:46:21 UTC
Verified the fix in test2 environment
Comment 6 Rummana Yasmeen 2014-03-14 20:01:28 UTC
Verified the fix in production: https://en.wikipedia.org/wiki/User:RYasmeen_(WMF)/sandbox?veaction=edit

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links