Last modified: 2014-04-27 10:58:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63597, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 61597 - ConfirmEdit should pass jshint
ConfirmEdit should pass jshint
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
ConfirmEdit (CAPTCHA extension) (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Aalekh Nigam
: javascript
Depends on:
Blocks: jshint
  Show dependency tree / graph
 
Reported: 2014-02-20 13:29 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-04-27 10:58 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-02-20 13:29:40 UTC 
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Gerrit Notification Bot 2014-03-28 03:28:54 UTC 
Change 121573 had a related patch set uploaded by AalekhN:
Confirm Edit now passes jslint, so make it voting

https://gerrit.wikimedia.org/r/121573
Comment 2 Gerrit Notification Bot 2014-03-28 15:00:38 UTC 
Change 121573 abandoned by Hashar:
Confirm Edit now passes jslint, so make it voting

Reason:
ConfirmEdit does not pass jshint for me and dies out with 86 errors.  Please get the javascript updated in mediawiki/extensions/ConfirmEdit.git then reopen this change :]

https://gerrit.wikimedia.org/r/121573
Comment 3 Gerrit Notification Bot 2014-03-30 18:21:46 UTC 
Change 122126 had a related patch set uploaded by AalekhN:
ConfirmEdit should pass jshint

https://gerrit.wikimedia.org/r/122126
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links