Last modified: 2014-03-17 19:03:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63560, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 61560 - VisualEditor: Revert image |link= hack for Parsoid bug 49844
VisualEditor: Revert image |link= hack for Parsoid bug 49844
Status: RESOLVED INVALID
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-19 22:06 UTC by C. Scott Ananian
Modified: 2014-03-17 19:03 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description C. Scott Ananian 2014-02-19 22:06:47 UTC 
Parsoid's bug 49844 with link attributes has been fixed.

In https://bugzilla.wikimedia.org/show_bug.cgi?id=49844#c5 James Forrester wrote:

This is worked around (albeit with potentially a bit of a hack) in VisualEditor, so not so important now from VisualEditor's POV.

Now that the parsoid fix has been deployed (for a while now), I'm opening a new bug to revert Visual Editor's hack.
Comment 1 Gerrit Notification Bot 2014-02-19 22:27:30 UTC 
Change 114352 had a related patch set uploaded by Jforrester:
Revert "Set href attribute of newly inserted image to image title"

https://gerrit.wikimedia.org/r/114352
Comment 2 Gerrit Notification Bot 2014-02-20 21:37:18 UTC 
Change 114352 merged by jenkins-bot:
Revert "Set href attribute of newly inserted image to image title"

https://gerrit.wikimedia.org/r/114352
Comment 4 C. Scott Ananian 2014-03-17 18:37:39 UTC 
I believe the reversion is correct.  Clarified the spec: https://www.mediawiki.org/w/index.php?title=Parsoid%2FMediaWiki_DOM_spec&diff=931265&oldid=931084
VE's current behavior matches the spec.
Comment 5 Gerrit Notification Bot 2014-03-17 18:39:28 UTC 
Change 119087 had a related patch set uploaded by Cscott:
Clarified the default link for image insertion.

https://gerrit.wikimedia.org/r/119087
Comment 6 Gerrit Notification Bot 2014-03-17 18:40:42 UTC 
Change 119088 had a related patch set uploaded by Jforrester:
Remove commented-out, now-confirmed-as-wrong wrong image insertion code

https://gerrit.wikimedia.org/r/119088
Comment 7 Gerrit Notification Bot 2014-03-17 18:45:03 UTC 
Change 119087 merged by jenkins-bot:
Clarified the default link for image insertion.

https://gerrit.wikimedia.org/r/119087
Comment 8 Gerrit Notification Bot 2014-03-17 18:58:49 UTC 
Change 119088 merged by jenkins-bot:
Remove commented-out, now-confirmed-as-wrong wrong image insertion code

https://gerrit.wikimedia.org/r/119088
Comment 9 James Forrester 2014-03-17 19:03:15 UTC 
As discussed, this wasn't a hack, this was the right thing to do, so INVALIDing this bug.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links