Last modified: 2014-03-20 22:28:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63152, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61152 - VisualEditor: Selecting "None" as position in Media Settings>Advanced Settings shifts the image to the right of the page
VisualEditor: Selecting "None" as position in Media Settings>Advanced Setting...
Status: RESOLVED WORKSFORME
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Moriel Schottlender
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-10 19:45 UTC by Rummana Yasmeen
Modified: 2014-03-20 22:28 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (103.92 KB, image/png)
2014-02-10 19:45 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-02-10 19:45:41 UTC
Created attachment 14546 [details]
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Insert an image
3.Go to Media Settings>Advanced Settings for the image
4.Select the value "None" under the postion 

Observed Result:
Selecting "None" as position in Media Settings>Advanced Settings shifts the image to the right of the page

See the screenshot attached.
Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/wiki/10thFeb
Comment 1 Rummana Yasmeen 2014-02-10 19:49:23 UTC
After that , Selecting Right moves the image to the left
Comment 2 Moriel Schottlender 2014-02-11 21:46:56 UTC
I can't manage to replicate this bug in master. "None" shifts the image to the left in an English wiki, and right in an RTL wiki (Hebrew on my local machine)

That said, this fix changes the behavior of the position widget. I tested it under that commit as well and couldn't replicate in both Chrome and Firefox.

https://gerrit.wikimedia.org/r/#/c/112041/
Comment 3 Moriel Schottlender 2014-02-11 22:49:57 UTC
When I try this in betalabs, the image shifts to the left of the page when I select "None", as expected.

There is, however, another bug where the image doesn't have an *initial* position visible in the editor. That is fixed in the upcoming commit that I mentioned above.
Comment 4 James Forrester 2014-03-20 22:28:02 UTC
Think this is OK now?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links