Last modified: 2014-02-16 21:14:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62916, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60916 - The links to "Mobile" and "Desktop" at the bottom are not separated
The links to "Mobile" and "Desktop" at the bottom are not separated
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
http://fa.m.wikipedia.org/
: i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-05 21:25 UTC by Amir E. Aharoni
Modified: 2014-02-16 21:14 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Chrome getting it right (92.46 KB, image/png)
2014-02-10 19:52 UTC, Henry Smith
Details
Firefox getting it wrong (107.97 KB, image/png)
2014-02-10 19:53 UTC, Henry Smith
Details
Firefox getting it right with the help of a zero-width non-joiner (90.09 KB, image/png)
2014-02-10 22:21 UTC, Henry Smith
Details

Description Amir E. Aharoni 2014-02-05 21:25:32 UTC
The elements with "Mobile" and "Desktop" at the bottom of the page are not separated in any way. They appear one right after another in the HTML code without any space. These two elements are <li>s with display: inline.

If the language of the site is written in Arabic letters, then Firefox thinks that this is a consecutive word and connects the last Arabic letter of the first element to the first letter of the second element. This happens even though CSS inserts space between the elements.

This doesn't happen in WebKit. I am not sure what is the correct standard browser behavior here.

Inserting an nbsp or a zwnj between the two elements would resolve the problem, albeit in a somewhat ugly way.
Comment 1 Bingle 2014-02-05 21:40:37 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1670
Comment 2 Jon 2014-02-05 21:41:12 UTC
Could you provide screenshots? Not completely clear what this is referring to...
They are separating using :before and :after on more modern browsers with a | symbol. Not sure what behaviour is on other browsers.

What browser are you seeing this issue in?
Comment 3 Amir E. Aharoni 2014-02-08 22:07:17 UTC
(In reply to comment #2)
> What browser are you seeing this issue in?

Firefox desktop.

This bug started a very curious discussion among CSS standard makers about what is the Right Standard Behavior for browsers in this case.

Until it's resolved uniformly in all browsers, I guess that there should be an nbsp or a zwnj, as suggested in the opening report.
Comment 4 Henry Smith 2014-02-10 19:52:53 UTC
Created attachment 14547 [details]
Chrome getting it right
Comment 5 Henry Smith 2014-02-10 19:53:40 UTC
Created attachment 14548 [details]
Firefox getting it wrong
Comment 6 Henry Smith 2014-02-10 19:59:25 UTC
Could I get this assigned? I have a fix ready.
Comment 7 Gerrit Notification Bot 2014-02-10 22:17:25 UTC
Change 112595 had a related patch set uploaded by Henry:
Add zero-width non-joiner to fix Arabic ligature issue affecting Firefox users

https://gerrit.wikimedia.org/r/112595
Comment 8 Henry Smith 2014-02-10 22:21:11 UTC
Created attachment 14549 [details]
Firefox getting it right with the help of a zero-width non-joiner
Comment 9 Gerrit Notification Bot 2014-02-12 19:58:20 UTC
Change 112595 merged by jenkins-bot:
Add zero-width non-joiner to fix Arabic ligature issue affecting Firefox users

https://gerrit.wikimedia.org/r/112595
Comment 10 Arthur Richards 2014-02-12 21:32:04 UTC
Merged, marking as fixed.
Comment 11 Amir E. Aharoni 2014-02-13 19:53:16 UTC
As a matter of curiosity, this bug started a pretty big discussion in the WWW mailing lists:
http://lists.w3.org/Archives/Public/www-international/2014JanMar/thread.html
(Search for "Arabic letters connecting between elements with display: inline")
Comment 12 Amir E. Aharoni 2014-02-13 19:53:35 UTC
(I meant W3C mailing lists.)
Comment 13 Jon 2014-02-16 19:08:41 UTC
Super interesting. I love it when we cause a stir in the W3C :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links