Last modified: 2014-04-11 00:53:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62804, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 60804 - VisualEditor: Creating a link while selecting an image modified the link inside the caption
VisualEditor: Creating a link while selecting an image modified the link insi...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-04-03
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-04 02:23 UTC by Rummana Yasmeen
Modified: 2014-04-11 00:53 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot of the error (186.50 KB, image/png)
2014-02-04 02:26 UTC, Rummana Yasmeen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-02-04 02:23:55 UTC 
Steps to reproduce:

1.Open a page with VE
2.Insert a image
3.Open the media settings for the image
4.Insert a link as a caption
5.Save the page
6.Reopen the page and select the image
7.Open the link inspector and type in a different a link inside it
8.Save the page
9.Reopen the page and the Media Settings for the image

Observed Result:
The link inside the caption got changed by the link inserter in step 7

Test Environment: https://test2.wikipedia.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5 
Page:https://test2.wikipedia.org/w/index.php?title=3rdfebFF&veaction=edit
Comment 1 Rummana Yasmeen 2014-02-04 02:26:14 UTC 
Created attachment 14472 [details]
Screenshot of the error
Comment 2 Rummana Yasmeen 2014-04-01 20:54:32 UTC 
If there are multiple links inside the media caption then the link applied outside the image gets applied to all other links .
Comment 3 Gerrit Notification Bot 2014-04-02 20:06:44 UTC 
Change 123429 had a related patch set uploaded by Esanders:
Skip over handlesOwnChildren nodes in newFromAnnotation

https://gerrit.wikimedia.org/r/123429
Comment 4 Gerrit Notification Bot 2014-04-02 20:10:15 UTC 
Change 123429 merged by jenkins-bot:
Skip over handlesOwnChildren nodes in newFromAnnotation

https://gerrit.wikimedia.org/r/123429
Comment 5 Rummana Yasmeen 2014-04-08 21:30:40 UTC 
Verified the fix in mediawiki.org
Comment 6 Rummana Yasmeen 2014-04-11 00:53:23 UTC 
Verified the fix in production
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links