Last modified: 2006-05-26 19:16:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T8080, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 6080 - Prevent users from uploading images with + in name
Prevent users from uploading images with + in name
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
PC Windows XP
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2006-05-25 09:57 UTC by Marco
Modified: 2006-05-26 19:16 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Marco 2006-05-25 09:57:05 UTC
An user has uploaded the image [[de:Image:Fussel+Socke.jpg]] without knowing
that + is the urlencode for spaces. So this image is not accessible for bots and
the IE.

May someone fix the image name and put some preventer in the MediaWiki code please?
Comment 1 Brion Vibber 2006-05-25 10:10:49 UTC
This should work fine with bots and IE. Can you provide a more 
detailed description of the problem?
Comment 2 Marco 2006-05-25 10:16:10 UTC
I can not see the image when I click on
(HTTP 4o4)

In Firefox all things are normal.

I requested the preventer because the + char is normally the URLENCODEd char for
" "s and so it is possible (especially for mirrors!) that there can problems result.
Comment 3 Brion Vibber 2006-05-25 19:30:47 UTC
This URL works just fine in IE 6.0 / Win98 and IE 7beta2 / WinXP.
Note that:
1) + has no special meaning in URL path components.
2) %2b is used for encoding the + in any case.
Comment 4 Marco 2006-05-26 15:32:23 UTC
for 1): try in PHP5  the line <? echo urldecode("Fussel+Socke.jpg"); ?>; it will
echo "Fussel Socke.jpg".
for 2): try in PHP5  the line <? echo urldecode("Fussel%2BSocke.jpg"); ?>; it
will echo "Fussel Socke.jpg".
(note: I tested on Windows XP SP1, maybe that PHP behaves different, then bug is
for wreck)

Comment 5 Brion Vibber 2006-05-26 18:26:16 UTC
The statement above is false: your second code fragment in fact 
outputs "Fussel+Socke.jpg", as expected.
Comment 6 Marco 2006-05-26 19:16:00 UTC
Ah, I think I know the reason:
It is the file encoding. When it is UTF-8, then the PHP snipps will act as I
told. When it is other charset (yeah, Turkish also works), it acts as you've told.
Strange thing.

Note You need to log in before you can comment on or make changes to this bug.