Last modified: 2014-01-27 17:46:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62475, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60475 - default limit
default limit
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Search (Other open bugs)
1.23.0
All All
: Unprioritized normal (vote)
: 1.23.0 release
Assigned To: Chad H.
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-27 16:20 UTC by physikerwelt
Modified: 2014-01-27 17:46 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description physikerwelt 2014-01-27 16:20:07 UTC
Why does SearchEngine::Create set the default limit to 0 whereas the default value in the class is set to 10. 
ll 488: 		$search->setLimitOffset( 0, 0 );
class SearchEngine {
ll 33:	var $limit = 10;
I'd vote to change the default limit for new instances to 10 as well.
Comment 1 Gerrit Notification Bot 2014-01-27 16:55:56 UTC
Change 109679 had a related patch set uploaded by Chad:
Don't override limits and offsets in SearchEngine::create()

https://gerrit.wikimedia.org/r/109679
Comment 2 Gerrit Notification Bot 2014-01-27 17:46:16 UTC
Change 109679 merged by jenkins-bot:
Don't override limits and offsets in SearchEngine::create()

https://gerrit.wikimedia.org/r/109679

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links