Last modified: 2006-05-20 08:10:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 6015 - Add spacing in the boxes "edit is minor" and "watch this"
Add spacing in the boxes "edit is minor" and "watch this"
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-05-18 16:14 UTC by Rotem Liss
Modified: 2006-05-20 08:10 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch (trunk) (1.17 KB, patch)
2006-05-18 16:22 UTC, Rotem Liss
Details
Patch (REL1_6) (1.17 KB, patch)
2006-05-18 16:27 UTC, Rotem Liss
Details

Description Rotem Liss 2006-05-18 16:14:48 UTC
In the boxes "edit is minor" and "watch this", and in "watch this" and "ignore
warnings" in the upload page, the boxes are very close to the text. I suggest to
add a space between the boxes themselves and the text, and between each box to
another.

For example, now it's:

XEdit is minorXWatch this

(It is not shown that way, but it's so in the code.)

I suggest:

X Edit is minor X Watch this

The fix should be done in includes/EditPage.php and in
includes/SpecialUpload.php, as far as I understand.

This fix should be backported to REL1_6, as it's very minor.
Comment 1 Rotem Liss 2006-05-18 16:22:46 UTC
Created attachment 1779 [details]
Patch (trunk)

This patch fixes the problem. By the way, the problem is already fixed in the
upload page. Patch for REL1_6 is coming soon.
Comment 2 Rotem Liss 2006-05-18 16:27:35 UTC
Created attachment 1780 [details]
Patch (REL1_6)

The same.
Comment 3 Platonides 2006-05-18 20:47:18 UTC
Adding an \n ? Wouldn't be better using a table and having them centered below
the comment textbox?
Comment 4 Platonides 2006-05-18 20:49:49 UTC
I didn't undertand it well. It's ok as it's proposed.
Comment 5 Antoine "hashar" Musso (WMF) 2006-05-20 08:10:09 UTC
Commited in:
- trunk r14306
- REL1_6 r14307

Should hit 1.6.6. Thanks for the patch!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links