Last modified: 2011-03-12 15:39:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 6006 - Allow disabling password changes when using an AuthPlugin
Allow disabling password changes when using an AuthPlugin
Status: CLOSED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-05-17 17:47 UTC by D.J. Capelis
Modified: 2011-03-12 15:39 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch against trunk/phase3/includes/AuthPlugin.php (443 bytes, patch)
2006-05-17 18:14 UTC, D.J. Capelis
Details
Patch against trunk/phase3/includes/SpecialPreferences.php (2.56 KB, patch)
2006-05-17 18:24 UTC, D.J. Capelis
Details

Description D.J. Capelis 2006-05-17 17:47:08 UTC
Writing an authentication extension for Shibboleth
(http://shibboleth.internet2.edu) and found that there doesn't seem to be a
great way to hide the password change field on the preferences page from an
extension... this remedies that.

Fix consists of two patches:
*First patch is against the AuthPlugin class to add another function call
(canSetPassword) that returns whether or not a the passwords can be changed in
the external database.
*Second patch is for the preferences page to check this nd if it finds that it
can't change a password in the external database, not display the password
change form on that page.
Comment 1 D.J. Capelis 2006-05-17 18:14:01 UTC
Created attachment 1768 [details]
Patch against trunk/phase3/includes/AuthPlugin.php
Comment 2 D.J. Capelis 2006-05-17 18:24:16 UTC
Created attachment 1769 [details]
Patch against trunk/phase3/includes/SpecialPreferences.php
Comment 3 D.J. Capelis 2006-05-23 17:27:47 UTC
I know there was some IRC discussion on the bug, but can someone comment here on
what exactly they'd like to see changed?
Comment 4 Rob Church 2006-06-26 22:35:04 UTC
The patch hides the form controls, but doesn't filter the POST values when the
request is submitted, so there's still scope for the input to be processed.
Comment 5 D.J. Capelis 2006-06-27 20:50:41 UTC
Except for the fact that the input is _already_ filtered out.

This just updates the form controls to reflect that the input is going to be
rejected.
Comment 6 Rob Church 2006-06-29 00:58:27 UTC
Fixed in SVN trunk, r15139.
Comment 7 D.J. Capelis 2006-06-29 18:48:43 UTC
Verified, removed keywords.  Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links