Last modified: 2014-02-20 02:56:41 UTC
If there is a compilation error with the less files, the only exception we get is Warning: array_map(): An error occurred while invoking the map callback in /home/santhosh/dev/wiki/core/includes/resourceloader/ResourceLoaderFileModule.php This is not helpful. Because array maps cannot properly report errors from callbacks. Roan already reported this issue at PHP with a patch. https://bugs.php.net/bug.php?id=55416 but not accepted at upstream. Can't we modify the code in readStyleFiles of ResourceLoaderFileModule a bit so that we get sensible stack trace and saves time in debugging? instead of array map, it can be something like $style= ""; foreach ( $files as $file ) { $style = $style . "\n". $this->readStyleFile( $file, $flip ); } $styles[$media] = $style; What I expect is a helpful error message like: exception 'Exception' with message '.mw-ui-one-third is undefined: failed at `.mw-ui-one-third;` /home/santhosh/dev/wiki/ContentTranslation/modules/base/styles/base.less on line 27' in /home/santhosh/dev/wiki/core/includes/libs/lessc.inc.php:3527
Change 109956 had a related patch set uploaded by Santhosh: Unroll array_map in ResourceLoaderFileModule::readStyleFiles https://gerrit.wikimedia.org/r/109956
Change 106486 abandoned by Santhosh: Avoid array_map to get useful debug information about LESS errors Reason: Abandoning in favor of I7c48b2c94752eee81f0eeb8e00d1f2b526d80dfc Same approach is used in that patch https://gerrit.wikimedia.org/r/106486
Change 109956 merged by jenkins-bot: Unroll array_map in ResourceLoaderFileModule::readStyleFiles https://gerrit.wikimedia.org/r/109956
successfully merged
Thanks Umherirrender.
