Last modified: 2014-02-14 14:30:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61781, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59781 - VisualEditor: Wikitext is appearing in the readmode for the numbered list and bullet list that is inside reference dialog box
VisualEditor: Wikitext is appearing in the readmode for the numbered list and...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-02-06
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-07 19:19 UTC by Rummana Yasmeen
Modified: 2014-02-14 14:30 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
In the read mode (28.44 KB, image/png)
2014-01-07 19:19 UTC, Rummana Yasmeen
Details
In Edit mode (15.51 KB, image/png)
2014-01-07 19:20 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-01-07 19:19:19 UTC
Created attachment 14249 [details]
In the read mode

Steps to reproduce:

1.Open a page with VE
2.Add a reference to a text by going to Insert>Reference
3.When the reference dialog box opens up insert a numbered list and then type the reference for example as: 1.reference
4.Click on "Insert Reference"
5.Save the page

Observed Result:
In the read mode,the serials of the numbered list are appearing in wikitext with #.

See the screenshot attached

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Jan7th
Comment 1 Rummana Yasmeen 2014-01-07 19:20:17 UTC
Created attachment 14250 [details]
In Edit mode
Comment 2 Rummana Yasmeen 2014-01-08 20:35:01 UTC
This issue is also occurring for bullet list thats is added inside Reference dialog bix, they appear as * in the Read mode
Comment 3 Ed Sanders 2014-02-05 20:03:23 UTC
One really shouldn't put lists inside a reference. References are supposed to be a single paragraph. I'll remove the tools for doing so which should reduce the impact of this.
Comment 4 Ed Sanders 2014-02-05 20:04:04 UTC
https://gerrit.wikimedia.org/r/#/c/111507/
Comment 5 Ed Sanders 2014-02-06 08:48:10 UTC
Todo: create a ticket for the Parsoid side if this bug (not inserting line breaks before */#)
Comment 6 James Forrester 2014-02-13 19:42:21 UTC
(In reply to Ed Sanders from comment #5)
> Todo: create a ticket for the Parsoid side if this bug (not inserting line
> breaks before */#)

Ed, what's the specific problem Parsoid's doing wrong?

<p>Hey!<span class="reference" data-mw="{&quot;name&quot;:&quot;ref&quot;,&quot;body&quot;:{&quot;html&quot;:&quot;&lt;ul &gt;&lt;li &gt; foo&lt;/li&gt;&lt;li &gt; bar&lt;/li&gt;&lt;li &gt; baz&lt;/li&gt;&lt;/ul&gt;&quot;},&quot;attrs&quot;:{}}" id="cite_ref-1-0" rel="dc:references" typeof="mw:Extension/ref"><a href="#cite_note-1">[1]</a></span></p>

… goes neatly to …

Hey!<ref>* foo
* bar
* baz</ref>

With \n as needed.
Comment 7 Ed Sanders 2014-02-14 14:30:49 UTC
The PHP parser requires a \n before every *, including the first one. So it should be:

Hey!<ref>
* foo
* ...

Unless you want to start messing with the PHP parser...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links