Last modified: 2014-06-04 11:19:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 5970 - Need to login to upload files
Need to login to upload files
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 6208 7287 (view as bug list)
Depends on: 3732
Blocks:
  Show dependency treegraph
 
Reported: 2006-05-15 21:12 UTC by Geoffrey
Modified: 2014-06-04 11:19 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch (trunk) (638 bytes, patch)
2006-06-05 15:43 UTC, Rotem Liss
Details
Patch (REL1_6) (638 bytes, patch)
2006-06-05 15:44 UTC, Rotem Liss
Details

Description Geoffrey 2006-05-15 21:12:02 UTC
I've set the following lines in my LocalSettings.php file: 

$wgGroupPermissions['*']['upload']          = true;
$wgGroupPermissions['*']['reupload']        = true;
$wgGroupPermissions['*']['reupload-shared'] = true;

but when I try to upload a file without logging in, I get the message saying
"You must be logged in to upload files."

Uploads work fine for logged-in users.
Comment 1 Brion Vibber 2006-05-15 21:13:11 UTC
The logging infrastructure currently requires that users be 
logged in to perform this action.
Comment 2 Geoffrey 2006-05-15 21:23:24 UTC
Is this going to be changed/updated?
Comment 3 Rotem Liss 2006-06-05 15:42:53 UTC
*** Bug 6208 has been marked as a duplicate of this bug. ***
Comment 4 Rotem Liss 2006-06-05 15:43:35 UTC
Created attachment 1905 [details]
Patch (trunk)

This patch rewrites this piece of code, so that all the messages will be shown
only if the upload is forbidden; if the user is anonymous, a message tells him
to log in – and if not, a message tells him he should have a permission.
Comment 5 Rotem Liss 2006-06-05 15:44:11 UTC
Created attachment 1906 [details]
Patch (REL1_6)

Please note that this fix should be also backported, as the bug is very
important for several wikis, and the fix is small. Thanks.
Comment 6 Rotem Liss 2006-06-05 15:48:51 UTC
We can even give an anonymous user the right to delete pages, or move them, or
block users – if we are crazy. Why can't we allow him to upload images, which is
much harmless feature?

However, I don't say it should be set by default (it absolutely shouldn't be
so), but it should be possible to set.
Comment 7 Rob Church 2006-06-05 15:56:17 UTC
The fix will not be useful until the logging table contains the aforementioned field.
Comment 8 Rotem Liss 2006-08-23 15:30:52 UTC
Applied to trunk in r16199.

(In reply to comment #7)
> The fix will not be useful until the logging table contains the aforementioned
field.

You are right, however we shouldn't have such mistakes in the permissions
system, even if another bug makes them "legitimate". When the other bug is
fixed, we may forget to fix this small bug, for example.
Comment 9 Rotem Liss 2006-09-11 16:01:27 UTC
*** Bug 7287 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links