Last modified: 2014-01-30 19:52:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61670, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 59670 - Uploading too many files in more than one batch creates error message with confusing numbers


Summary:	Uploading too many files in more than one batch creates error message with co...

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	UploadWizard (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	messages
	Show dependency tree / graph

Reported:	2014-01-05 10:50 UTC by Liangent
Modified:	2014-01-30 19:52 UTC (History)
CC List:	9 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Possible patch (1.04 KB, patch) 2014-01-14 22:00 UTC, Ocean behind ears	Details
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2014-01-05 10:50:43 UTC

Repro:

1. Prepare 51 files.
2. Go to Upload Wizard, "Upload" step.
3. Add two files first.
4. Add all remaining files.
5. It says "Too many files" "You can only upload 50 files at once but you tried to upload 49 files in total. Please try again with fewer files!"

This message is confusing, because obviously 49 < 50.

Comment 1 Ocean behind ears 2014-01-14 22:00:41 UTC

Created attachment 14308 [details]
Possible patch

This should fix the problem

Comment 2 Andre Klapper 2014-01-15 09:34:41 UTC

Hi! Thanks for your patch!

You are welcome to use Developer access
  https://www.mediawiki.org/wiki/Developer_access
to submit this as a Git branch directly into Gerrit:
  https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier to review it quickly. If you don't want to set up Git/Gerrit, you can also use https://tools.wmflabs.org/gerrit-patch-uploader/
Thanks again! We appreciate your contribution.

Comment 3 Gerrit Notification Bot 2014-01-26 22:17:18 UTC

Change 109602 had a related patch set uploaded by Ocean behind ears:
Fix counting error

https://gerrit.wikimedia.org/r/109602

Comment 4 Gerrit Notification Bot 2014-01-27 10:43:29 UTC

Change 109602 merged by jenkins-bot:
Fix counting error

https://gerrit.wikimedia.org/r/109602

Comment 5 Ocean behind ears 2014-01-28 00:21:42 UTC

Please close this bug.

Comment 6 Andre Klapper 2014-01-28 08:50:53 UTC

Ah. Thanks (for the reminder and the patch)!

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links