Last modified: 2007-04-26 20:28:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T7959, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 5959 - Anchors dropped from stub links
Anchors dropped from stub links
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.7.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/Wikipedi...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-05-15 13:11 UTC by Stuart Orford
Modified: 2007-04-26 20:28 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Stuart Orford 2006-05-15 13:11:59 UTC
If you have stub display enabled, then links to stubs that include anchor links,
e.g. [[Foo#Bar]], render as a link to just [.../wiki/Foo]. With stub display
turned off, or for articles over the stub display threshold, is renders
correctly as [.../wiki/Foo#Bar]. See URL for example of [[February 29#Births]].
(I only noticed it because my stub threshold is set very high at the moment -
presumably there aren't many cases where one would need to link to a section of
a stub :)
Comment 1 Rob Church 2006-06-29 01:23:25 UTC
Links to stubs including an anchor show up fine for me using SVN trunk, r15139.
Let me check the details:

"Foo" is a stub containing a "links" section. I link to [[Foo]] and
[[Foo#Links]] from another page, and set the stub threshold to ~100. Both the
wiki links show up brown, etc.

Seems to be working...?
Comment 2 Stuart Orford 2006-06-29 08:19:09 UTC
It looks like the link text displays as "Foo#Links", but the actual link target
is still just "http://.../wiki/Foo". See test page at [[User:Sjorford/Test stub
links]].
Comment 3 Phil Boswell 2006-06-29 08:23:52 UTC
(In reply to comment #0)
> See URL for example of [[February 29#Births]]

This link contains a space, which is converted to %20 and then to an underscore: 
my Mark 1 eyeball suggests that it is the latter conversion which drops the 
anchor...

Does [[February_29#Births]] suffer from the same problem? (curses to the lack of 
preview which means I have to ask rather than simply stating yeah or nay!)

Comment 4 Phil Boswell 2006-06-29 08:24:49 UTC
(In reply to comment #3)
> Does [[February_29#Births]] suffer from the same problem?

That would be a "no", although stupid IE refuses to actually jump to the anchor :-(
Comment 5 Stuart Orford 2006-06-29 08:34:15 UTC
(In reply to comment #3)
> Does [[February_29#Births]] suffer from the same problem? (curses to the lack of 
> preview which means I have to ask rather than simply stating yeah or nay!)

Er...all the links work fine *here*, because this is Bugzilla, not MediaWiki -
or have I completely misunderstood what you're saying? On EN Wikipedia I still
get the problem with [[February 29#Births]], [[February_29#Births]], and
[[Lincoln#Culture]], using several skins and both IE and Firefox.
Comment 6 Rob Church 2006-06-29 12:06:07 UTC
(In reply to comment #2)
> It looks like the link text displays as "Foo#Links", but the actual link target
> is still just "http://.../wiki/Foo". See test page at [[User:Sjorford/Test stub
> links]].

Good lord, I must be going blind. Yes, confirmed.
Comment 7 Antoine "hashar" Musso (WMF) 2007-04-26 20:28:21 UTC
Fixed in r21635

Linker::makeStubLinkObj had its own logic to handle links, it now
load the style and call Linker::makeKnownLinkObj.


Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links