Last modified: 2011-03-12 15:34:47 UTC
I'm currently working on an extension to integrate Shibboleth (http://shibboleth.internet2.edu/) and Mediawiki and it would be great if MediaWiki had some hooks to add to $personal_urls. A patch to SkinTemplate.php and hooks.txt will be included in with this bug to do this shortly.
Created attachment 1648 [details] Patch against 1.6.3 SkinTemplate
Created attachment 1649 [details] Patch against 1.6.3 hooks.txt
Any chance these patches could be provided in unified diff format against SVN trunk?
Probably should have just done that in the first place... sorry about that.
Created attachment 1658 [details] Patch against trunk/phase3/docs/hooks.txt
Created attachment 1659 [details] Patch against trunk/phase3/includes/SkipTemplate.php
I'd be inclined to suggest using the one hook, called after the defaults had been added.
That's all I'm using anyways, I just figured adding one before would allow for more flexibility, regardless, here's a patch to use one hook instead.
Created attachment 1676 [details] Modified version of patch 1659 with only one hook
Created attachment 1677 [details] Modified version of patch 1659 with only one hook (Correct) I was editing my previous patch with vim... apparently it's helpful if you edit the patch correctly. :-\
Created attachment 1678 [details] Modified version of patch 1658 with only one hook And here's the modified documentation changes.
Applied a modified form in SVN trunk, r13138.
(In reply to comment #12) > Applied a modified form in SVN trunk, r13138. That's r14138, excuse me.
Modified form has a flaw: Line was modified to: wfRunHooks( 'PersonalUrls', array( $personal_urls, $wgTitle ) ); Should be: wfRunHooks( 'PersonalUrls', array( &$personal_urls, $wgTitle ) ); If we can get this last character corrected that would be great.
Argh. Fixed in SVN trunk, r14261.
Fix and hook verified, thanks again. :)
