Last modified: 2011-03-12 15:34:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 5819 - Extra Hooks for $personal_urls
Extra Hooks for $personal_urls
Status: CLOSED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-05-03 19:21 UTC by D.J. Capelis
Modified: 2011-03-12 15:34 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch against 1.6.3 SkinTemplate (737 bytes, patch)
2006-05-03 19:44 UTC, D.J. Capelis
Details
Patch against 1.6.3 hooks.txt (691 bytes, patch)
2006-05-03 19:44 UTC, D.J. Capelis
Details
Patch against trunk/phase3/docs/hooks.txt (669 bytes, patch)
2006-05-05 16:44 UTC, D.J. Capelis
Details
Patch against trunk/phase3/includes/SkipTemplate.php (659 bytes, patch)
2006-05-05 16:45 UTC, D.J. Capelis
Details
Modified version of patch 1659 with only one hook (369 bytes, patch)
2006-05-07 02:23 UTC, D.J. Capelis
Details
Modified version of patch 1659 with only one hook (Correct) (369 bytes, patch)
2006-05-07 02:34 UTC, D.J. Capelis
Details
Modified version of patch 1658 with only one hook (514 bytes, patch)
2006-05-07 02:35 UTC, D.J. Capelis
Details

Description D.J. Capelis 2006-05-03 19:21:54 UTC
I'm currently working on an extension to integrate Shibboleth
(http://shibboleth.internet2.edu/) and Mediawiki and it would be great if
MediaWiki had some hooks to add to $personal_urls.

A patch to SkinTemplate.php and hooks.txt will be included in with this bug to
do this shortly.
Comment 1 D.J. Capelis 2006-05-03 19:44:04 UTC
Created attachment 1648 [details]
Patch against 1.6.3 SkinTemplate
Comment 2 D.J. Capelis 2006-05-03 19:44:29 UTC
Created attachment 1649 [details]
Patch against 1.6.3 hooks.txt
Comment 3 Rob Church 2006-05-05 12:34:47 UTC
Any chance these patches could be provided in unified diff format against SVN trunk?
Comment 4 D.J. Capelis 2006-05-05 16:43:48 UTC
Probably should have just done that in the first place... sorry about that.
Comment 5 D.J. Capelis 2006-05-05 16:44:58 UTC
Created attachment 1658 [details]
Patch against trunk/phase3/docs/hooks.txt
Comment 6 D.J. Capelis 2006-05-05 16:45:31 UTC
Created attachment 1659 [details]
Patch against trunk/phase3/includes/SkipTemplate.php
Comment 7 Rob Church 2006-05-06 15:37:05 UTC
I'd be inclined to suggest using the one hook, called after the defaults had
been added.
Comment 8 D.J. Capelis 2006-05-07 02:22:36 UTC
That's all I'm using anyways, I just figured adding one before would allow for
more flexibility, regardless, here's a patch to use one hook instead.
Comment 9 D.J. Capelis 2006-05-07 02:23:50 UTC
Created attachment 1676 [details]
Modified version of patch 1659 with only one hook
Comment 10 D.J. Capelis 2006-05-07 02:34:51 UTC
Created attachment 1677 [details]
Modified version of patch 1659 with only one hook (Correct)

I was editing my previous patch with vim... apparently it's helpful if you edit
the patch correctly. :-\
Comment 11 D.J. Capelis 2006-05-07 02:35:55 UTC
Created attachment 1678 [details]
Modified version of patch 1658 with only one hook

And here's the modified documentation changes.
Comment 12 Rob Church 2006-05-08 22:21:32 UTC
Applied a modified form in SVN trunk, r13138.
Comment 13 Rob Church 2006-05-08 22:22:00 UTC
(In reply to comment #12)
> Applied a modified form in SVN trunk, r13138.

That's r14138, excuse me.
Comment 14 D.J. Capelis 2006-05-16 23:17:03 UTC
Modified form has a flaw:

Line was modified to:
wfRunHooks( 'PersonalUrls', array( $personal_urls, $wgTitle ) );

Should be:
wfRunHooks( 'PersonalUrls', array( &$personal_urls, $wgTitle ) );

If we can get this last character corrected that would be great.
Comment 15 Rob Church 2006-05-17 07:02:39 UTC
Argh. Fixed in SVN trunk, r14261.
Comment 16 D.J. Capelis 2006-05-17 07:49:48 UTC
Fix and hook verified, thanks again. :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links