Last modified: 2013-05-13 21:15:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 5798 - With no text content in footer, footer becomes shorter than image content
With no text content in footer, footer becomes shorter than image content
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.11.x
All All
: Low trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-05-02 22:21 UTC by dean
Modified: 2013-05-13 21:15 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of the problem (104.26 KB, image/x-png)
2006-05-02 22:23 UTC, dean
Details

Description dean 2006-05-02 22:21:38 UTC
When a skin is adjusted to have less items in the footer, and a particular page has 
the remaining ones disabled, the height of the footer shrinks to less than the height 
of the contained images.

This is visible (at least in IE7) on one of my history pages:
http://hashvb.earlsoft.co.uk/?title=VB.net_UnloadMode&action=history

I have the footer list set to:
$footerlinks = array 
('lastmod', 'viewcount', 'numberofwatchingusers', 'credits', 'copyright', 'tagline');
Comment 1 dean 2006-05-02 22:23:30 UTC
Created attachment 1644 [details]
Screenshot of the problem

This shows the bug in action
Comment 2 dean 2006-05-04 22:32:00 UTC
I've tried giving it a fixed height but then it wont expand to show the text when 
its in there.
Unfortunately, I don't know enough CSS to do it properly.
Comment 3 Robert Leverington 2007-07-07 18:46:18 UTC
This is a problem with the way divs work. The div is only the height of the actual content -  so placing a non-breaking space at the base of the div (below everything else in it) will solve the problem. I have also experienced a similar problem before with Google siteads - this is a problem with your wiki and a solution needn't be put in the codebase as it is not a problem for users who aren't messing about with the files.
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-07-08 03:28:23 UTC
We could add a min-height rule for the footer, but that would cause trouble for people customizing the skin in a different way (i.e., replacing the images with shorter ones).  I concur that this is not an issue reasonably fixable by MediaWiki.
Comment 5 Jelte (WebBoy) 2007-07-08 09:54:53 UTC
You could add <div style="clear: both;"></div> to the end of the footer.
Comment 6 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-07-08 19:45:41 UTC
Problematic as-is because in the default setup, that shoves down the lower border, due to padding.  Possibly something based on that idea would work, however.

On consideration, we do allow people to configure away all those messages at the bottom without hacking the files.  So we should probably support it looking good without manual CSS modifications if you do that, although it's not very important.  Reopening in case someone can come up with a good solution that won't change existing layouts.
Comment 7 Gerrit Notification Bot 2013-05-13 13:02:31 UTC
Related URL: https://gerrit.wikimedia.org/r/63458 (Gerrit Change I337bab53600efb4cb27b65b01d62f59968a4fba9)
Comment 8 Gerrit Notification Bot 2013-05-13 13:33:09 UTC
https://gerrit.wikimedia.org/r/63458 (Gerrit Change I337bab53600efb4cb27b65b01d62f59968a4fba9) | change APPROVED and MERGED [by jenkins-bot]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links