Last modified: 2014-05-19 15:18:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59627, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57627 - Jenkins should identify voting test failures more prominently
Jenkins should identify voting test failures more prominently
Status: RESOLVED WORKSFORME
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-26 22:54 UTC by Ori Livneh
Modified: 2014-05-19 15:18 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ori Livneh 2013-11-26 22:54:10 UTC
This is somewhat related to bug 35943. I see this sort of thing regularly:

14:45 <jackmcbarn> why is jenkins-bot failing my commit for stuff i didn't touch?
14:45 <jackmcbarn> https://gerrit.wikimedia.org/r/#/c/97855/
14:46 <ori-l> jackmcbarn: it's the last failure that is causing it to veto
14:46 jackmcbarn looks

The meaning of '(non-voting)' is not very obvious, I think. We ask human reviewers to be explicit in identifying their grounds for -1 patches; I don't see why Jenkins-bot couldn't be held to the same standard :)

IMHO, just exclude non-voting tests from Jenkins's comments. Do people actually look at them?
Comment 1 Antoine "hashar" Musso (WMF) 2014-05-19 15:18:02 UTC
The non-voting jobs are there for information. People do look at them, for example the PHP CodeSniffer ones being run on MediaWiki core.   Whenever they are reliably passing, they are made voting.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links