Last modified: 2013-11-25 18:41:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59497, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57497 - MassMessage's HTML syntax checker should recognize when a problem has been fixed
MassMessage's HTML syntax checker should recognize when a problem has been fixed
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MassMessage (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Kunal Mehta (Legoktm)
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-24 06:59 UTC by Quim Gil
Modified: 2013-11-25 18:41 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Quim Gil 2013-11-24 06:59:55 UTC
Currently MassMessage includes a basic HTML checker that triggers a dialog when e.g. a closing tag is potentially missing. However, the dialog stays after fixing the problem.

Maybe it is worth looking at how the Translate extension checks formatting, since it has a similar feature and error messages do disappear when you type what is missing.
Comment 1 Kunal Mehta (Legoktm) 2013-11-24 07:56:49 UTC
I just tried locally this on the REL1_22 branch, and once I close the HTML tag, the notice goes away.

What browser/OS are you using? Are there any errors in your JavaScript console?
Comment 2 Quim Gil 2013-11-25 06:53:17 UTC
I see what happens. The warning dialog disappears when closing the HTML tag, but the dialog will stay if you solve the problem by deleting the HTML tag altogether.

I found this problem pasting some text containing one HTML tag, and only one because it was just a sentence of a paragraph. I didn't need any HTML formatting, so I removed the tag.
Comment 3 Gerrit Notification Bot 2013-11-25 06:57:13 UTC
Change 97481 had a related patch set uploaded by Legoktm:
If there are no matches, null is returned

https://gerrit.wikimedia.org/r/97481
Comment 4 Kunal Mehta (Legoktm) 2013-11-25 07:03:28 UTC
Thanks, turns out it was throwing a syntax error if there were no HTML tags left.
Comment 5 Gerrit Notification Bot 2013-11-25 18:32:44 UTC
Change 97481 merged by jenkins-bot:
If there are no matches, null is returned

https://gerrit.wikimedia.org/r/97481
Comment 6 Kunal Mehta (Legoktm) 2013-11-25 18:41:12 UTC
I'm not going to backport this to REL1_22 since there's nothing in master that requires 1.23 right now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links