Last modified: 2014-03-14 17:45:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59477, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57477 - VisualEditor: If the initial selection is a node (i.e. the document only contains nodes, no text), show the appropriate inspector icon
VisualEditor: If the initial selection is a node (i.e. the document only cont...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Lowest minor
: ---
Assigned To: Editing team bugs – take if you're interested!
:
: 62650 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-23 08:35 UTC by Nikola Smolenski
Modified: 2014-03-14 17:45 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nikola Smolenski 2013-11-23 08:35:36 UTC
Steps to reproduce:

1. Go to https://en.wikipedia.org/wiki/Wax_foundation
2. Click on "Edit".

The first image is automatically selected, and its four corners are replaced with image resizing icons, but "Media" image editing icon is not shown. I expected that the image would not be selected, or if selected that image editing icon is shown.

3. Click on the second image.
4. Click again on the first image. Now the image editing icon should be shown.
5. Click on the image editing icon.
6. Click on the word "frame". Link editing icon should be shown.
7. Click on the link editing icon.
8. Enter "Beehive frame" (without quotes) in the text box.
9. Click on "Apply changes".
10. Click on "Save page". "Save your changes" dialogue appears.
11. Click on "Save page" in the new dialogue.

The VisualEditor displays "Your changes to Wax foundation have been saved.", but nothing has actually been saved.

Now, I see three bugs here:

1) The first image should not be selected automatically.
2) Possibly I have to do something after entering the link target in order for the target to be "applied" to the image caption? But I don't see what it is that I should do.
3) The editor shouldn't display "changes have been saved" message when there are no changes to be saved; doing so prevents the people from knowing that what they did was not saved, regardless of whether there was an error on their part or on the VisualEditor part.
Comment 1 Elitre 2013-11-25 16:58:21 UTC
I'll leave the first question to others, for the other ones:
2) You need to make sure that you select the word you want (then you click on it, press Enter, whatever). Try and review your changes before you save: is it there now? If it is, you should be able to save and your edit should stay in the page history. If it isn't, please let us know the browser (and its version) and Wikipedia skin you use.
3) I experienced something similar back in July: https://bugzilla.wikimedia.org/show_bug.cgi?id=51243 .
Comment 2 Nikola Smolenski 2013-11-26 08:01:18 UTC
1.1) I believe the image should not be selected, but I understand people might have different opinion about it.

1.2) But if the image is selected, then the icon must be shown as well. I see this as an obvious bug.

2)

OK, it appears that in order for the link to be applied, I have to click on < icon in the top left corner of the link editing box; or, I have to press Enter twice; or, click in the text editing box and then in the space below it(?).

To me, and I believe other editors, this is very unintuitive. Perhaps < icon could be changed to ✓ - I see < as signifying 'Undo' rather than 'Apply'. Perhaps "Apply changes" should be ghosted when there are no chages to apply. But even with these changes I don't see how I could intuitively know what I should do.

The "Review your changes" button shows correctly whether I have any changes.
Comment 3 Ed Sanders 2014-02-14 14:37:36 UTC
We now try to select the nearest content branch, so this bug is only reproduceable if the document consists of just an image.
Comment 4 James Forrester 2014-03-14 17:42:32 UTC
*** Bug 62650 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links