Last modified: 2011-03-13 18:06:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 5747 - Wikipedia default edit toolbar not displaying button images
Wikipedia default edit toolbar not displaying button images
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
PC Windows 2000
: Lowest normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-04-28 19:02 UTC by John Nagle
Modified: 2011-03-13 18:06 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screen shot of all-text toolbar (82.16 KB, image/gif)
2006-04-30 05:32 UTC, John Nagle
Details
Button images as displayed in Firefox (20.61 KB, image/gif)
2006-04-30 16:47 UTC, John Nagle
Details
Firefox extensions dialog for failing browser (17.55 KB, image/gif)
2006-05-01 08:00 UTC, John Nagle
Details
Capture of HTTP Headers (1.21 KB, text/plain)
2006-08-29 14:26 UTC, Hugues Freville
Details
Capture of HTTP Headers (44.80 KB, text/plain)
2006-08-29 15:12 UTC, Hugues Freville
Details
Capture of HTTP Headers from private mediawiki server (17.86 KB, text/plain)
2006-08-29 15:19 UTC, Hugues Freville
Details
Check for dom.disable_image_src_set (1.09 KB, patch)
2008-10-20 14:48 UTC, Platonides
Details

Description John Nagle 2006-04-28 19:02:58 UTC
The Wikipedia default edit toolbar is not displaying button images.  Reloaded
page, reloaded Firefox, cleared cache, upgraded Firefox to latest 1.5.0.2 - no
improvement.  Problem first appeared about two weeks ago.
Comment 1 Brion Vibber 2006-04-29 21:23:29 UTC
Works fine for everyone else. Please provide details such as:
1) presence of any local "windows firewall" etc
2) which skin is selected in preferences
3) any custom javascript on your account
4) under what circumstances you have tested
Comment 2 John Nagle 2006-04-29 22:27:29 UTC
Developer claims "Works fine for everyone else".  Please verify.

Works in: Mozilla Firebird 0.7+ on QNX 6.21
Does not work in: Mozilla Firefox 1.5 on Windows 2000.
Does not work in: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.2)
Gecko/20060308 Firefox/1.5.0.2.  Upgrade did NOT help. 
1. No "Windows firewall" is present on Windows 2000 machine.
2. Default skin.
3. No custom javascript on Wikipedia account.
4. Browser plugins: FlashBlock.  Repeated trials over a week.  Worked until
roughly mid-April. 
Comment 3 Brion Vibber 2006-04-29 22:58:11 UTC
Works fine in Mozilla Firefox 1.5.0.2 on Mac OS X 10.4.

Installed FlashBlock extension (1.33), they still work.

Please provide a screen shot if possible, and confirm that JavaScript is enabled.
Comment 4 John Nagle 2006-04-30 05:32:20 UTC
Created attachment 1629 [details]
Screen shot of all-text toolbar

As requested, here's a screen shot of the text-only toolbar.
Javascript is enabled, and in fact, the text buttons in the toolbar work
correctly.  But the images won't display.
Comment 5 Platonides 2006-04-30 14:14:10 UTC
I can only reproduce a similar behaviour if i disable images. But then the buddy
icon nor the wikipedia logo would appear!

Does it correctly handle that png images? That wouldn't be a satisfactory
explanation as http://en.wikipedia.org/images/wiki-en.png is png but could lead
us somewhere.

On the other hand, you could see them before :S Try to see the images without
the toolbar: http://en.wikipedia.org/skins-1.5/common/images/button_bold.png
http://upload.wikimedia.org/wikipedia/en/c/c8/Button_redirect.png
Comment 6 Marco 2006-04-30 14:15:18 UTC
It depends on server load. When it is too heavy, sewrver denies image delivery.
Comment 7 John Nagle 2006-04-30 16:47:10 UTC
Created attachment 1632 [details]
Button images as displayed in Firefox

The button images are readable in my browser when read directly, but not when
via the toolbar Javascript.  See attached screenshot.  So the images are valid,
they're being read OK, they're in the browser's cache OK, the image site isn't
blocked, and Firefox can display them. They just won't display in the toolbar.
Comment 8 Brion Vibber 2006-05-01 07:11:19 UTC
Still works absolutely here in Firefox on Windows XP. The fact that you
can load the images fine lends credence to it being some sort of extension 
on your end that's breaking things deliberately.

Can you show a screenshot of your extensions dialog to confirm what's 
installed and what versions?
Comment 9 John Nagle 2006-05-01 08:00:43 UTC
Created attachment 1633 [details]
Firefox extensions dialog for failing browser

As requested, the extensions dialog for the failing browser.
(What's so striking about all this is that it all worked fine until about a
week ago.)
Comment 10 John Nagle 2006-05-16 18:57:40 UTC
Still failing.

Reported by someone else on Wikipedia at
"http://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Getting_confusing_text_instead_of_edit-buttons"
Comment 11 Platonides 2006-05-16 19:59:16 UTC
It was also reported at spanuich village pump on 2nd May. Using sistema Windows
2000 too.
I pointed him here, but seems it didn't come.
http://es.wikipedia.org/wiki/Wikipedia:Caf%C3%A9_%28ayuda%29#Desaparici.C3.B3n_barra_de_edici.C3.B3n
Comment 12 John Nagle 2006-06-04 16:50:27 UTC
Still failing, and more Wikipedia users are complaining. See
http://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Edit_buttons_not_working_in_Firefox
Comment 13 Brion Vibber 2006-06-04 18:47:48 UTC
John, can you do this for me?

1) Clear cache and clear your cookie for en.wikipedia.org.
2) Install "Live HTTP Headers" extension
(from http://livehttpheaders.mozdev.org/ )
3) Open up 'Live HTTP Headers' window from the Tools menu
4) Click the 'Config' tab
5) Uncheck 'Exclude URLs with regexp'
6) Leave the window open, but click over to a regular Firefox window.
7) Go to http://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&action=edit
8) Go back to the 'Live HTTP headers' window, click on the 'Headers' tab
9) Click 'Save All...' to save the recorded HTTP data to a file.
10) Attach the file here.
Comment 14 John Nagle 2006-06-04 18:57:57 UTC
Sorry, we don't install browser extensions.  Perhaps if you asked on Wikipedia
Village Pump you might find someone willing to do this.  
Comment 15 Brion Vibber 2006-06-04 19:08:01 UTC
You seemed to have no problem with installing Flashblock
(visible in your screen shot) yet you're not willing to
help diagnose the problem you keep complaining about?
Comment 16 Hugues Freville 2006-08-29 14:26:43 UTC
Created attachment 2282 [details]
Capture of HTTP Headers
Comment 17 Platonides 2006-08-29 14:48:28 UTC
Make a full refresh (Ctrl+F5). You should be loading a lot more items
(page+images+scripts+css...)
Comment 18 Hugues Freville 2006-08-29 15:12:34 UTC
Created attachment 2283 [details]
Capture of HTTP Headers
Comment 19 Hugues Freville 2006-08-29 15:19:28 UTC
Created attachment 2284 [details]
Capture of HTTP Headers from private mediawiki server

This is the traffic between firefox and "my" private mediawiki(1.7) server


The "toolbar" problem only apears only on my firefox (1.5.0.6) on windows XP
(firefox (1.5.0.6) on another computer have no problem)

Maybe, the problem is related to flashblock
I also use this extension, i tried to disabled and uninstalled it
but with no effects
Maybe, flashblock change some firefox files which are not restored upon
uninstall
Comment 20 Platonides 2006-08-29 21:32:44 UTC
It seems you have a proxy between you and the server. This proxy is probably
called http://isa-4.oddo.fr/ It is stopping you once and again from delivering
the data, asking for authentication. Then your broser autentifies and is 'logged
in' for a couple of requests. Then the proxy asks for auth again...

For pages you authenticate and it works. For images, you authentiate but the
proxy denies authentication. However, some images pass the third time.

This proxy is a good candidate for being guilty.

Your brwser doesn't seem to _ask_ for the images so it could also be the js is
not properly giving it to you. Does flashblock (or any other extension you use)
have the ability to change you browser identification? (what matters is in front
of javascript, not user-agent). As the toolbar is conditionally added, could
also be of importance (but then you shouldn't see the toolbar at all! :S)

Comment 21 Hugues Freville 2006-08-30 08:46:52 UTC
I saw the proxy messages in the capture id=2283
so i created the capture id=2284 where no proxy are involved


I'dont know a lot about flashblock, but i don't think it change my browser
identification.
I installed User Agent Switcher and switching my identification to
InternetExplorer 6 
doesn't change anything :-(

I'll try to find a computer where i can test if flashblock is responsible or not

Comment 22 John Nagle 2006-12-09 20:48:40 UTC
Here's the problem, and how to fix it.

Those buttons are no longer part of the static page; they're being added by
JavaScript code.  That's not always allowed. 

Firefox can be in a configuration state where trying to change the "src"
attribute of an "img" element is prohibited. No JavaScript error is reported,
but the change does not take place.   If "dom.disable_image_src_set" is set to
"true" in "about.config", such changes are prohibited, and the buttons will
disappear. Google Maps won't work. either.  

This is likely to have happened for users who upgraded from Firefox 1.0 to 1.5
or 2.  Firefox 1.0 had an options check box which controlled this configuration
parameter, as part of some early attempts at ad filtering.  That option check
box was removed in 1.5, but users who upgraded from 1.0 are then stuck at their
old setting. The Firefox upgrader didn't handle this well.

If you open "about:config", find "dom.disable_image_src_set", and reset it to
the default value ("false"), the buttons should reappear. 

Ref:   http://kb.mozillazine.org/Images_or_animations_don%27t_load 
Comment 23 MZMcBride 2008-10-20 07:52:46 UTC
Can this be marked as resolved now?
Comment 24 Platonides 2008-10-20 14:48:34 UTC
Created attachment 5450 [details]
Check for dom.disable_image_src_set

I don't think so. It's still the same issue if someone has dom.disable_image_src_set to true (although few people will do now).
I think this should be reported upstream. It's a Firefox bug that the image src can't be set before it is attached to the document DOM.

What we can do is to detect the problem and show an error message. I attach a proposal. It just shows a hardcoded string on the toolbar if it was unable to set the src property of the image, it's so uncommon it isn't worth to localize.
Comment 25 Alex Z. 2009-07-21 04:42:58 UTC
WONTFIX - This appears to only apply to ancient versions of Firefox and people with odd custom settings, I don't see why we should go out of our way to support this.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links