Last modified: 2013-12-04 11:39:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58903, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 56903 - Wikibase\EntityView::getBasicEntityInfo must not load full data for all referenced entities.
Wikibase\EntityView::getBasicEntityInfo must not load full data for all refer...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Highest critical (vote)
: ---
Assigned To: Wikidata bugs
: performance
Depends on:
Blocks: 54098
  Show dependency tree / graph
 
Reported: 2013-11-11 12:16 UTC by Daniel Kinzler
Modified: 2013-12-04 11:39 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2013-11-11 12:16:59 UTC 

    


      




        
          Comment 1
        

        
          Daniel Kinzler

        

        
        

        
          2013-11-11 12:20:36 UTC
        
      





Wikibase\EntityView::getBasicEntityInfo currently loops over all referenced entities, loads each of them, and then generates a serialization only containing labels, descriptions and data types (see EntityRevisionSerializer::newForFrontendStore). 

This is causing serious performance issues (in terms of time as well as memory).

The solution would be to load labels and descriptions from the terms table, and the data type from the property_info table. We'll also have to grab the revision info from the page table (joining against entity_per_page).

    


      




        
          Comment 2
        

        
          Gerrit Notification Bot

        

        
        

        
          2013-11-19 17:28:38 UTC
        
      





Change 94738 merged by jenkins-bot:
(bug #56903) Introducing EntityInfoBuilder

https://gerrit.wikimedia.org/r/94738

    


      




        
          Comment 3
        

        
          abraham.taherivand

        

        
        

        
          2013-11-20 13:42:26 UTC
        
      





Verified in Wikidata demo time.

    



  






  


    

      

        

          
            

              Note
              You need to
              log in
              before you can comment on or make changes to this bug.
            

          		
        
 
      

  
        





        




  
  First
  Last
  Prev
  Next
    
  This bug is not in your last
    search results.







			

			
		
		
		
		
		
		
			

				
				
				
				
				

					
Navigation

					

						
					

				

				
				
				
				
				

					
Links